Vinzenz Feenstra has posted comments on this change. Change subject: Allow to avoid lock screen on spice disconnect ......................................................................
Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/34079/22/packaging/dbscripts/upgrade/03_06_1450_add_vm_static_console_disconnect_action.sql File packaging/dbscripts/upgrade/03_06_1450_add_vm_static_console_disconnect_action.sql: Line 1: select fn_db_add_column('vm_static', 'console_disconnect_action', 'VARCHAR(64)'); > Eli you can see the values, in this patch: Well I have added NULL handling and the column is not marked as 'NOT NULL' therefore that shouldn't be a problem. I can by default make them all 'LOCK_SCREEN' however using NULL is less prone to programming errors due to potential typos. 64 Chars is plenty, and not supposed to be user defined content. It all comes from the enums. -- To view, visit https://gerrit.ovirt.org/34079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2ef5ffaceed619f6630b56a7156f25e9111fd9e Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
