[Engine-patches] Change in ovirt-engine[master]: Mark VM as problematic when timezone or OS changed

[vfeenstr]

Vinzenz Feenstra has posted comments on this change.

Change subject: Mark VM as problematic when timezone or OS changed
......................................................................


Patch Set 8:

(4 comments)

https://gerrit.ovirt.org/#/c/30508/8/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VmStatusCell.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VmStatusCell.java:

Line 139:             String html = imagePrototype.getHTML();
Line 140: 
Line 141:             // Append tooltip
Line 142:             EnumTranslator translator = EnumTranslator.getInstance();
Line 143:             String toolTip = "";
> miss the //$NON-NLS-1$
Done
Line 144:             if(updateNeeded) {
Line 145:                toolTip = constants.newtools();
Line 146:             } else if(vm.getStatus() != VMStatus.Up) {
Line 147:                toolTip = translator.translate(vm.getVmPauseStatus());


Line 149:             if(timezoneDiffers) {
Line 150:                 if(toolTip.length() > 0) {
Line 151:                     toolTip += " | "; //$NON-NLS-1$
Line 152:                 }
Line 153:                 constants.guestTimezoneDiffers();
> tooltip += ... :)
Done
Line 154:             }
Line 155:             if(osTypeDiffers) {
Line 156:                 if(toolTip.length() > 0) {
Line 157:                     toolTip += " | "; //$NON-NLS-1$


Line 155:             if(osTypeDiffers) {
Line 156:                 if(toolTip.length() > 0) {
Line 157:                     toolTip += " | "; //$NON-NLS-1$
Line 158:                 }
Line 159:                 toolTip += " | " + constants.guestOSDiffers(); 
//$NON-NLS-1$
> you put the "|" twice here
Done
Line 160:             }
Line 161: 
Line 162:             html = html.replaceFirst("img", "img " + "title='" + 
toolTip + "' "); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$
Line 163: 


Line 185:             if (javaZoneId != null) {
Line 186:                 offset = 
TimeZoneType.GENERAL_TIMEZONE.getStandardOffset(javaZoneId);
Line 187:             }
Line 188:         }
Line 189:         if(vm.getTimezoneOffset() != offset) {
> if the timeZone == null (or empty) than the offset is going to stay 0. 
Good catch
Line 190:             return true;
Line 191:         }
Line 192: 
Line 193:         return false;


-- 
To view, visit https://gerrit.ovirt.org/30508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1d6c878a3e700998c77d3ee3248b4ef3302d08b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches