Vinzenz Feenstra has posted comments on this change. Change subject: backend: Implementation support for GuestOsInfo and Timezone reporting ......................................................................
Patch Set 15: (3 comments) https://gerrit.ovirt.org/#/c/29322/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ArchitectureType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ArchitectureType.java: Line 34: Line 35: public static ArchitectureType forValue(int value) { Line 36: return valueToArchitecture.get(value); Line 37: } Line 38: public static ArchitectureType forValue(String value) { > enum already have valueOf built in just for that Done Line 39: for(Map.Entry<Integer, ArchitectureType> e : valueToArchitecture.entrySet()) { Line 40: if(e.getValue().name().equals(value)) { Line 41: return e.getValue(); Line 42: } https://gerrit.ovirt.org/#/c/29322/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java: Line 666: this.guestOsType = guestOsType; Line 667: } Line 668: Line 669: @JsonIgnore Line 670: public void setGuestOsType(String osType) { > instead of this method, which would need to be updated in case the enum upd Done Line 671: osType = osType.toLowerCase(); Line 672: if(osType.equals("linux")) { Line 673: this.guestOsType = OsType.Linux; Line 674: } https://gerrit.ovirt.org/#/c/29322/15/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 3794: <value>0</value> Line 3795: <null /> Line 3796: <null /> Line 3797: <value>0</value> <!-- guest_agent_status --> Line 3798: <null/> > please remove whitespace Done Line 3799: <null/> Line 3800: <value>0</value> Line 3801: <null/> Line 3802: <null/> -- To view, visit https://gerrit.ovirt.org/29322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1e54d39706601c0faf9d76785f1257ee20755b Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
