Vinzenz Feenstra has posted comments on this change. Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting ......................................................................
Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/41813/4/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 3312: Line 3313: <xs:complexType name="GuestOs"> Line 3314: <xs:sequence> Line 3315: <xs:element name="arch" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3316: <xs:element name="codename" type="xs:string" minOccurs="1" maxOccurs="1"/> > What is the difference between "name" and "codename"? Don't we need a "name a code name is e.g. Heisenbug for Fedora 20 or trusty for Ubuntu 14.04 It's not the actual name. The actual name is something which can be put together from all the information included in this complex type. This is how it is represented from the guest agent: distribution=Fedora version=20 codename=Heisenbug arch=x86_64 kernel=3.18.9-100.fc20.x86_64 type=linux distribution=Ubuntu version=14.04 codename=trusty arch=x86_64 kernel=3.18.9-100.fc20.x86_64 type=linux NOTE: The ubuntu kernel version here is off because I am running this in docker, so the kernel is actually a F20 kernel ;-) but otherwise it's similar Line 3317: <xs:element name="distribution" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3318: <xs:element name="kernel_version" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3319: <xs:element name="type" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3320: <xs:element name="version" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3314: <xs:sequence> Line 3315: <xs:element name="arch" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3316: <xs:element name="codename" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3317: <xs:element name="distribution" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3318: <xs:element name="kernel_version" type="xs:string" minOccurs="1" maxOccurs="1"/> > May we want to report other kernel parameters in the future (command line, ok, will do, however the kernel version I won't be able to put into the Version complex type. Line 3319: <xs:element name="type" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3320: <xs:element name="version" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3321: </xs:sequence> Line 3322: </xs:complexType> Line 3315: <xs:element name="arch" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3316: <xs:element name="codename" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3317: <xs:element name="distribution" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3318: <xs:element name="kernel_version" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3319: <xs:element name="type" type="xs:string" minOccurs="1" maxOccurs="1"/> > What is "type"? Windows, Linux, etc? In that case consider naming it "famil Done Line 3320: <xs:element name="version" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 3321: </xs:sequence> Line 3322: </xs:complexType> Line 3323: -- To view, visit https://gerrit.ovirt.org/41813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I492d42248858fc653918a33e972734bd82be1eec Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
