Vinzenz Feenstra has posted comments on this change. Change subject: restapi: Implementation for GuestOsInfo and Timezone reporting ......................................................................
Patch Set 13: (3 comments) https://gerrit.ovirt.org/#/c/41813/13/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java: Line 409: final boolean hasGuestOsVersion = entity.getGuestOsVersion() != null && !entity.getGuestOsVersion().isEmpty(); Line 410: if (hasGuestOsVersion) { Line 411: GuestOperatingSystem os = model.getGuestOperatingSystem(); Line 412: if(os == null) { Line 413: os = new GuestOperatingSystem(); > The "model.setGuestOperatingSystem(os)" call should go here, to call it onl Done Line 414: } Line 415: os.setArchitecture(entity.getGuestOsArch().name()); Line 416: os.setCodename(entity.getGuestOsCodename()); Line 417: os.setDistribution(entity.getGuestOsDistribution()); Line 428: os.setVersion(VersionMapper.map(version, null)); Line 429: os.getVersion().setFullVersion(entity.getGuestOsVersion()); Line 430: } Line 431: os.setFamily(entity.getGuestOsType().name()); Line 432: model.setGuestOperatingSystem(os); > Move this call to the "if (os == null)" block. Done Line 433: } Line 434: Line 435: final boolean hasTimezoneName = entity.getGuestOsTimezoneName() != null && !entity.getGuestOsTimezoneName().isEmpty(); Line 436: if (hasTimezoneName) { Line 433: } Line 434: Line 435: final boolean hasTimezoneName = entity.getGuestOsTimezoneName() != null && !entity.getGuestOsTimezoneName().isEmpty(); Line 436: if (hasTimezoneName) { Line 437: if(model.getGuestTimeZone() == null) { > Consider using a local variable: Done Line 438: model.setGuestTimeZone(new TimeZone()); Line 439: } Line 440: model.getGuestTimeZone().setName(entity.getGuestOsTimezoneName()); Line 441: model.getGuestTimeZone().setUtcOffset(TimeZoneMapper.mapUtcOffsetToDisplayString(entity.getGuestOsTimezoneOffset())); -- To view, visit https://gerrit.ovirt.org/41813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I492d42248858fc653918a33e972734bd82be1eec Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
