Sergey Gotliv has posted comments on this change.
Change subject: engine: Send net_ifacename to VDSM when connecting iSCSI server
..
Patch Set 1:
(3 comments)
Lior, thanks for review. I'll implement your suggestions in the nex
Sergey Gotliv has posted comments on this change.
Change subject: engine: Send net_ifacename to VDSM when connecting iSCSI server
..
Patch Set 1:
ping
--
To view, visit http://gerrit.ovirt.org/32383
To unsubscribe, visit http
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Send net_ifacename to VDSM when connecting iSCSI server
..
engine: Send net_ifacename to VDSM when connecting iSCSI server
In order to properly configur
Sergey Gotliv has posted comments on this change.
Change subject: engine: Improve iSCSI Bond CDA validation
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/26931
To unsubscribe, visit http://gerrit.ovirt.
Sergey Gotliv has posted comments on this change.
Change subject: core: Connect Storage Pool on iSCSI update
..
Patch Set 6: Code-Review+1
Maybe it worth to add an audit log message.
--
To view, visit http://gerrit.ovirt.org/
Sergey Gotliv has posted comments on this change.
Change subject: core: Connect Storage Pool on iSCSI update
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/27359/5/backend/manager/modules/bll/src/main/java/org/ovirt/e
Sergey Gotliv has posted comments on this change.
Change subject: core: Connect Storage Pool on iSCSI update
..
Patch Set 5: Code-Review-1
1. Adding try/catch inside a "public Void call()" will do the same, right? It
will fix
Sergey Gotliv has posted comments on this change.
Change subject: core: Connect Storage Pool on iSCSI update
..
Patch Set 4:
Just to make myself clear. According to the commit message this patch:
"There is no need to throw an
Sergey Gotliv has posted comments on this change.
Change subject: core: Connect Storage Pool on iSCSI update
..
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27359/4/backend/manager/modules/bll/src/main/ja
Sergey Gotliv has abandoned this change.
Change subject: restapi: Scan collections on model when adding links
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/26953
To unsubscribe, visit http://gerrit.ovirt.org/settings
Sergey Gotliv has posted comments on this change.
Change subject: restapi: Scan collections on model when adding links
..
Patch Set 2:
Sounds reasonable.
--
To view, visit http://gerrit.ovirt.org/26953
To unsubscribe, visit h
Sergey Gotliv has posted comments on this change.
Change subject: restapi: Add REST API support for iSCSI multipathing
..
Patch Set 4:
(3 comments)
http://gerrit.ovirt.org/#/c/26225/4/backend/manager/modules/restapi/interface/
Sergey Gotliv has posted comments on this change.
Change subject: engine: Improve iSCSI Bond CDA validation
..
Patch Set 1:
(8 comments)
http://gerrit.ovirt.org/#/c/26931/1/backend/manager/modules/bll/src/main/java/org/ovirt/e
Sergey Gotliv has posted comments on this change.
Change subject: restapi: Scan collections on model when adding links
..
Patch Set 1:
Juan,
What do you think about it?
--
To view, visit http://gerrit.ovirt.org/26953
To unsu
Sergey Gotliv has uploaded a new change for review.
Change subject: restapi: Scan collections on model when adding links
..
restapi: Scan collections on model when adding links
Change-Id: I148b9b690fad95b5ec0503beba254c1066a797f
Sergey Gotliv has posted comments on this change.
Change subject: restapi: Add REST API support for iSCSI multipathing
..
Patch Set 3:
(3 comments)
You are right, I will add tests.
http://gerrit.ovirt.org/#/c/26225/3/backend/
Sergey Gotliv has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 2: Verified+1
Rebase.
--
To view, visit http://gerrit.ovirt.org/26935
To unsubscribe, vis
Sergey Gotliv has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 1:
Juan,
Do you mean ovirt-engine/backend/manager/modules/restapi/interface/pom.xml?
I th
Sergey Gotliv has posted comments on this change.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26935
To unsubscribe, visit http:/
Sergey Gotliv has uploaded a new change for review.
Change subject: restapi: Simplify "combine" implementation in LinkHelper
..
restapi: Simplify "combine" implementation in LinkHelper
Change-Id: I21615f3036083fef2f83cc3cbc67f67
Sergey Gotliv has posted comments on this change.
Change subject: restapi: Add REST API support for iSCSI multipathing
..
Patch Set 3: Verified+1
I provided another patch to prevent managing iSCSI Bonds for datacenters < 3.4
-
Sergey Gotliv has posted comments on this change.
Change subject: engine: Improve iSCSI Bond CDA validation
..
Patch Set 1:
I still have to add unitests, but the general idea is - now, when iSCSI Bonds
are supported via REST A
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Improve iSCSI Bond CDA validation
..
engine: Improve iSCSI Bond CDA validation
Returns appropriate error message when trying to manage iSCSI Bonds via
r
Sergey Gotliv has posted comments on this change.
Change subject: restapi: [WIP] Add REST API support for iSCSI multipathing
..
Patch Set 2:
(1 comment)
Patch is still not complete.
1. I'll improve commit message.
2. rsdl_met
Sergey Gotliv has posted comments on this change.
Change subject: restapi: [WIP] Add REST API support for iSCSI multipathing
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26225/1/backend/manager/modules/restapi/inter
Sergey Gotliv has posted comments on this change.
Change subject: engine: Set default tpgt value to 1
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/26660
To unsubscribe, visit http://gerrit.ovirt.org/set
Sergey Gotliv has posted comments on this change.
Change subject: engine: Disable iSCSI multipathing for datacenters < 3.4
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/26661
To unsubscribe, visit http:/
Sergey Gotliv has posted comments on this change.
Change subject: engine: Send ifaceName and tpgt in connectStorageServer
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26659
To unsubscribe, visit http://
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Disable iSCSI multipathing for datacenters < 3.4
..
engine: Disable iSCSI multipathing for datacenters < 3.4
I had to fix a few issues in VDSM 3.4 in or
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Set default tpgt value to 1
..
engine: Set default tpgt value to 1
Engine uses wrong iSCSI terminology, portal instead of tpgt (target
portal group tag)
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Send ifaceName and tpgt in connectStorageServer
..
engine: Send ifaceName and tpgt in connectStorageServer
Engine mistakenly sent initiatorName instead
Sergey Gotliv has posted comments on this change.
Change subject: restapi: [WIP] Add REST API support for iSCSI multipathing
..
Patch Set 1:
I am still working on it...
--
To view, visit http://gerrit.ovirt.org/26225
To unsub
Sergey Gotliv has uploaded a new change for review.
Change subject: restapi: [WIP] Add REST API support for iSCSI multipathing
..
restapi: [WIP] Add REST API support for iSCSI multipathing
Enable adding, updating and removing iS
Sergey Gotliv has posted comments on this change.
Change subject: engine: Set default tpgt value to 1
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/26050
To unsubscribe, visit http://gerrit.ovirt.org/set
Sergey Gotliv has posted comments on this change.
Change subject: engine: Send ifaceName and tpgt in connectStorageServer
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/25890
To unsubscribe, visit http://
Sergey Gotliv has posted comments on this change.
Change subject: engine: Disable iSCSI multipathing for datacenters < 3.4
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/25962
To unsubscribe, visit http:/
Sergey Gotliv has posted comments on this change.
Change subject: engine: Set default tpgt value to 1
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/26050
To unsubscribe, visit http://gerrit.ovirt.org/set
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Set default tpgt value to 1
..
engine: Set default tpgt value to 1
Engine uses wrong iSCSI terminology, portal instead of tpgt (target
portal group tag)
Sergey Gotliv has posted comments on this change.
Change subject: engine: Send ifaceName and tpgt in connectStorageServer
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/25890/3/backend/manager/modules/vdsbroker/src/ma
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Disable iSCSI multipathing for datacenters < 3.4
..
engine: Disable iSCSI multipathing for datacenters < 3.4
VDSM introduced a few bug fixes in 3.4 to s
Sergey Gotliv has posted comments on this change.
Change subject: engine: Send ifaceName and tpgt in connectStorageServer
..
Patch Set 2:
I still have to provide one more patch that will limit the usage of the iscsi
bonds to 3
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Send ifaceName and tpgt in connectStorageServer
..
engine: Send ifaceName and tpgt in connectStorageServer
Engine mistakenly sent initiatorName instead
Sergey Gotliv has posted comments on this change.
Change subject: engine: Block setting a plugged disk as read only when the vm
is running
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25492
To unsub
Sergey Gotliv has abandoned this change.
Change subject: engine: Warn user when a boot disk is configured as read-only
..
Abandoned
Current decision is to close the bug as non issue. So meantime I abandon this
patch.
--
To
Sergey Gotliv has posted comments on this change.
Change subject: engine: Warn user when a boot disk is configured as read-only
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/24883/1/backend/manager/modules/bll/src/m
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Warn user when a boot disk is configured as read-only
..
engine: Warn user when a boot disk is configured as read-only
VM may fail to boot from a read-o
Sergey Gotliv has posted comments on this change.
Change subject: engine: Block setting a plugged disk as read only when the vm
is running
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24797
To unsubscr
Sergey Gotliv has posted comments on this change.
Change subject: engine: Block setting a plugged disk as read only when the vm
is running
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24797/2/backend/manager/module
Sergey Gotliv has abandoned this change.
Change subject: engine: Improve read-only disk validations
..
Abandoned
I'll split it into 2 patches. First of them is
http://gerrit.ovirt.org/#/c/24797/.
--
To view, visit http://ger
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Block setting a plugged disk as read only when the vm
is running
..
engine: Block setting a plugged disk as read only when the vm is running
Change-Id:
Sergey Gotliv has posted comments on this change.
Change subject: core: prevent maintenance when domain is still in use
..
Patch Set 12: Code-Review+1
(4 comments)
http://gerrit.ovirt.org/#/c/22045/12/backend/manager/modules/b
Sergey Gotliv has posted comments on this change.
Change subject: core: Add support for creating in memory tar
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/23466/8/backend/manager/modules/utils/src/main/java/org/ov
Sergey Gotliv has posted comments on this change.
Change subject: engine: Improve read-only disk validations
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/24680/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 201
Sergey Gotliv has posted comments on this change.
Change subject: engine: Introduce getConnectableStorageConnectionsByStorageType
API
..
Patch Set 2:
ping... Guys, please, approve this backport.
--
To view, visit http://gerr
Sergey Gotliv has posted comments on this change.
Change subject: engine: Improve read-only disk validations
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24680
To unsubscribe, visit http://gerrit.ovirt.
Sergey Gotliv has posted comments on this change.
Change subject: engine: Introduce getConnectableStorageConnectionsByStorageType
API
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24681
To unsubscribe,
Sergey Gotliv has posted comments on this change.
Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24682
To unsubscribe, visi
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Fix allocation policy and storage domain when editing
VM disk
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24686
To unsubscri
Sergey Gotliv has uploaded a new change for review.
Change subject: webadmin: Fix allocation policy and storage domain when editing
VM disk
..
webadmin: Fix allocation policy and storage domain when editing VM disk
Edit Vm disk
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond
..
engine: Only iSCSI storage connections are viable for iSCSI Bond
iSCSI Bond is the new manag
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Introduce getConnectableStorageConnectionsByStorageType
API
..
engine: Introduce getConnectableStorageConnectionsByStorageType API
This API allows to r
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Improve read-only disk validations
..
engine: Improve read-only disk validations
1. Validate that boot disk is read write.
2. Allow edit read-only attri
Sergey Gotliv has posted comments on this change.
Change subject: core: Use correct storage validation for MoveVM
..
Patch Set 1: Code-Review+1
I am wondering that this change didn't require any test changes :-).
--
To view,
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Display empty list when failed to retrieve list of
iso images
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24564
To unsubscri
Sergey Gotliv has uploaded a new change for review.
Change subject: webadmin: Display empty list when failed to retrieve list of
iso images
..
webadmin: Display empty list when failed to retrieve list of iso images
Change-Id: I
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Fix storage domain details in Edit VM Disk window
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24559
To unsubscribe, visit htt
Sergey Gotliv has uploaded a new change for review.
Change subject: webadmin: Fix storage domain details in Edit VM Disk window
..
webadmin: Fix storage domain details in Edit VM Disk window
This window displayed storage domain
Sergey Gotliv has posted comments on this change.
Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/23720
To unsubscribe, visi
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Fix allocation policy representation when editing VM
disk
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24532
To unsubscribe,
Sergey Gotliv has uploaded a new change for review.
Change subject: webadmin: Fix allocation policy representation when editing VM
disk
..
webadmin: Fix allocation policy representation when editing VM disk
Edit Vm disk window
Sergey Gotliv has posted comments on this change.
Change subject: engine: Remove javadoc from one of DiskValidator APIs
..
Patch Set 5:
Merge?
--
To view, visit http://gerrit.ovirt.org/23952
To unsubscribe, visit http://gerri
Sergey Gotliv has posted comments on this change.
Change subject: engine: Introduce getConnectableStorageConnectionsByStorageType
API
..
Patch Set 2:
Can someone merge it, please?
--
To view, visit http://gerrit.ovirt.org/24
Sergey Gotliv has posted comments on this change.
Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond
..
Patch Set 5:
Can someone merge it, please?
--
To view, visit http://gerrit.ovirt.org/23720
Sergey Gotliv has posted comments on this change.
Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond
..
Patch Set 5:
I verified that already. Pay, attention that it depends on another patch of
min
Sergey Gotliv has posted comments on this change.
Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/23720
To unsubscribe, visi
Sergey Gotliv has posted comments on this change.
Change subject: engine: Introduce getConnectableStorageConnectionsByStorageType
API
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24497
To unsubscribe,
Sergey Gotliv has posted comments on this change.
Change subject: engine: Modify GetAllConnectableStorageConnections procedure
and DAO
..
Patch Set 1:
Liron? Allon?
--
To view, visit http://gerrit.ovirt.org/24497
To unsubscr
Sergey Gotliv has posted comments on this change.
Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond
..
Patch Set 4:
I changed existing stored procedure due to Liron's and Allon's comments here
ht
Sergey Gotliv has posted comments on this change.
Change subject: engine: Modify GetAllConnectableStorageConnections procedure
and DAO
..
Patch Set 1:
I took Allon's and Liron's advise from here http://gerrit.ovirt.org/#/c/237
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Modify GetAllConnectableStorageConnections procedure
and DAO
..
engine: Modify GetAllConnectableStorageConnections procedure and DAO
Allows to retrieve
Sergey Gotliv has posted comments on this change.
Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond
..
Patch Set 3:
ping...
--
To view, visit http://gerrit.ovirt.org/23720
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: core: Fix DiskImageByDiskAliasComparator to handle null aliases
correctly
..
Patch Set 2: -Code-Review
Liron's suggestions sounds great.
--
To view, visit htt
Sergey Gotliv has posted comments on this change.
Change subject: core: Fix DiskImageByDiskAliasComparator to handle null aliases
correctly
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24269
To unsu
Sergey Gotliv has posted comments on this change.
Change subject: core: Fix DiskImageByDiskAliasComparator to handle null aliases
correctly
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24269/1//COMMIT_MSG
Commit Me
Sergey Gotliv has posted comments on this change.
Change subject: core: Change existing disk validation CDA message in case of
null disk alias
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/24276/1/back
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Confirmation window when putting storage domain on
maintenance
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24267
To unsubscr
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Add confirmation window when deactivating a VM disk
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24266
To unsubscribe, visit h
Sergey Gotliv has posted comments on this change.
Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond
..
Patch Set 3:
ping...
--
To view, visit http://gerrit.ovirt.org/23720
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Confirmation window when putting storage domain on
maintenance
..
Patch Set 1:
It seems like this bug doesn't contain any privileged information so I
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Add confirmation window when deactivating a VM disk
..
Patch Set 1:
I changed target version to 3.4.
--
To view, visit http://gerrit.ovirt.org/24266
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Add confirmation window when deactivating a VM disk
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24266
To unsubscribe, visit h
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Confirmation window when putting storage domain on
maintenance
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24267
To unsubscr
Sergey Gotliv has uploaded a new change for review.
Change subject: webadmin: Add confirmation window when deactivating a VM disk
..
webadmin: Add confirmation window when deactivating a VM disk
Change-Id: I13d9aa5386efd676d7b9d
Sergey Gotliv has uploaded a new change for review.
Change subject: webadmin: Confirmation window when putting storage domain on
maintenance
..
webadmin: Confirmation window when putting storage domain on maintenance
Change-Id:
Sergey Gotliv has posted comments on this change.
Change subject: engine: Use getFileStats to retrieve iso and floppy files
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24265
To unsubscribe, visit http:
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Use getFileStats to retrieve iso and floppy files
..
engine: Use getFileStats to retrieve iso and floppy files
VDSM introduced new API getFileStats in 3
Sergey Gotliv has posted comments on this change.
Change subject: webadmin: Prevent selection of IDE disk as read-only in UI
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24259
To unsubscribe, visit http
Sergey Gotliv has posted comments on this change.
Change subject: engine: Validate that IDE disk is not read-only
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24258
To unsubscribe, visit http://gerrit.o
Sergey Gotliv has uploaded a new change for review.
Change subject: webadmin: Prevent selection of IDE disk as read-only in UI
..
webadmin: Prevent selection of IDE disk as read-only in UI
Change-Id: I71856b447abc3bc3a48247c6df2
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Validate that IDE disk is not read-only
..
engine: Validate that IDE disk is not read-only
Real IDE disks can't be read-only therefore Engine has to val
1 - 100 of 752 matches
Mail list logo
