Sergey Gotliv has posted comments on this change. Change subject: core: Connect Storage Pool on iSCSI update ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/27359/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java: Line 49: host.getId(), Line 50: e); Line 51: } Line 52: } Line 53: } I think that this code will do the same without changing current multithreaded approach: for (final VDS host : hosts) { tasks.add(new Callable<Void>() { @Override public Void call() throws Exception { try { final List<StorageServerConnections> conns = ISCSIStorageHelper.updateIfaces(connections, host.getId()); runVdsCommand(VDSCommandType.ConnectStorageServer, new StorageServerConnectionManagementVDSParameters(host.getId(), Guid.Empty, StorageType.ISCSI, conns) ); } catch (VdcBLLException e) { ... } return null; } }); } Line 54: Line 55: /** Line 56: * Used by audit log to populate ${IscsiBondName} placeholder. Line 57: * @return -- To view, visit http://gerrit.ovirt.org/27359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b125471920792d8bfaae2327e6aa757c378ef0e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
