Sergey Gotliv has posted comments on this change. Change subject: restapi: Add REST API support for iSCSI multipathing ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/26225/4/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 4926: body: Line 4927: parameterType: IscsiBond Line 4928: signatures: Line 4929: - mandatoryArguments: {} Line 4930: optionalArguments: {} I have to update arguments for update due to Juan comment on previous patch. Line 4931: description: update the specified iSCSI Bond Line 4932: urlparams: {} Line 4933: headers: Line 4934: Content-Type: {value: application/xml|json, required: true} http://gerrit.ovirt.org/#/c/26225/4/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondResourceTest.java: Line 1: package org.ovirt.engine.api.restapi.resource; Line 2: Line 3: public class BackendIscsiBondResourceTest { Line 4: } I am still didn't implement tests. http://gerrit.ovirt.org/#/c/26225/4/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondsResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondsResourceTest.java: Line 33: Line 34: @Test Line 35: @Ignore Line 36: @Override Line 37: public void testList() throws Exception { working to enable test by test. Line 38: } Line 39: Line 40: @Test Line 41: @Ignore -- To view, visit http://gerrit.ovirt.org/26225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8881110cbeb163e9fc09e98bf4497d894f40490 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
