Sergey Gotliv has posted comments on this change. Change subject: core: Connect Storage Pool on iSCSI update ......................................................................
Patch Set 5: Code-Review-1 1. Adding try/catch inside a "public Void call()" will do the same, right? It will fix the bug without making a flow single threaded. 2. Suggest another patch to make the flow single threaded then we'll argue about that only. 3. Correct today all other flows work single threaded, but maybe if I want to connect 1000 hosts to 1000 targets via 2-3 Networks multithreaded is not so bad idea even if we'll need to modify ThreadUtils. -- To view, visit http://gerrit.ovirt.org/27359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b125471920792d8bfaae2327e6aa757c378ef0e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches