Sergey Gotliv has posted comments on this change. Change subject: engine: Improve iSCSI Bond CDA validation ......................................................................
Patch Set 1: (8 comments) http://gerrit.ovirt.org/#/c/26931/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java: Line 31: super(commandId); Line 32: } Line 33: Line 34: @Override Line 35: protected boolean canDoAction() { > Isn't checking the version is only enough for new iSCSI. Good point. I will move that part to AddIscsiBondCommand. Line 36: if (!FeatureSupported.isIscsiMultipathingSupported(getStoragePool().getcompatibility_version())) { Line 37: return failCanDoAction(VdcBllMessages.ISCSI_BOND_NOT_SUPPORTED); Line 38: } Line 39: Line 35: protected boolean canDoAction() { Line 36: if (!FeatureSupported.isIscsiMultipathingSupported(getStoragePool().getcompatibility_version())) { Line 37: return failCanDoAction(VdcBllMessages.ISCSI_BOND_NOT_SUPPORTED); Line 38: } Line 39: > Redundant empty line Done Line 40: return true; Line 41: } Line 42: Line 43: @Override http://gerrit.ovirt.org/#/c/26931/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EditIscsiBondCommand.java: Line 34: } Line 35: Line 36: @Override Line 37: protected boolean canDoAction() { Line 38: if (!super.canDoAction()) { > Why do we need to check if the iSCSI bond is supported if it is already exi Done Line 39: return false; Line 40: } Line 41: Line 42: IscsiBondValidator validator = new IscsiBondValidator(); http://gerrit.ovirt.org/#/c/26931/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveIscsiBondCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveIscsiBondCommand.java: Line 16: } Line 17: Line 18: @Override Line 19: protected boolean canDoAction() { Line 20: if (!super.canDoAction()) { > Why do we need to check if the iSCSI bond is supported if it is already exi Done Line 21: return false; Line 22: } Line 23: Line 24: IscsiBondValidator validator = new IscsiBondValidator(); http://gerrit.ovirt.org/#/c/26931/1/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1171: VALIDATION_SCSI_BOND_DESCRIPTION_INVALID=iSCSI Bond description must be formed only from alpha-numeric characters and special characters that conform to the standard ASCII character set. Line 1172: Line 1173: ISCSI_BOND_NOT_EXIST=Cannot ${action} ${type}. The specified iSCSI bond doesn't exist. Line 1174: ISCSI_BOND_WITH_SAME_NAME_EXIST_IN_DATA_CENTER=Cannot ${action} ${type}. iSCSI bond with the same name already exists in the Data Center. Line 1175: ISCSI_BOND_NOT_SUPPORTED=Cannot ${action} ${type}. iSCSI Bond is only supported on Data Center compatibility version 3.4 and higher. > s/version/versions Done Line 1176: http://gerrit.ovirt.org/#/c/26931/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3132: Line 3133: @DefaultStringValue("Cannot ${action} ${type}. The specified iSCSI bond doesn't exist.") Line 3134: String ISCSI_BOND_NOT_EXIST(); Line 3135: Line 3136: @DefaultStringValue("Cannot ${action} ${type}. iSCSI Bond is only supported on Data Center compatibility version 3.4 and higher.") > s/version/versions Done Line 3137: String ISCSI_BOND_NOT_SUPPORTED(); Line 3138: Line 3139: @DefaultStringValue("Cannot ${action} ${type}. An IDE disk can't be read-only.") Line 3140: String ACTION_TYPE_FAILED_IDE_INTERFACE_DOES_NOT_SUPPORT_READ_ONLY_ATTR(); http://gerrit.ovirt.org/#/c/26931/1/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1002: VALIDATION_SCSI_BOND_DESCRIPTION_INVALID=iSCSI Bond description must be formed only from alpha-numeric characters and special characters that conform to the standard ASCII character set. Line 1003: Line 1004: ISCSI_BOND_NOT_EXIST=Cannot ${action} ${type}. The specified iSCSI bond doesn't exist. Line 1005: ISCSI_BOND_WITH_SAME_NAME_EXIST_IN_DATA_CENTER=Cannot ${action} ${type}. iSCSI bond with the same name already exists in the Data Center. Line 1006: ISCSI_BOND_NOT_SUPPORTED=Cannot ${action} ${type}. iSCSI Bond is only supported on Data Center compatibility version 3.4 and higher. > s/version/versions Done Line 1007: http://gerrit.ovirt.org/#/c/26931/1/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1142: VALIDATION_SCSI_BOND_DESCRIPTION_INVALID=iSCSI Bond description must be formed only from alpha-numeric characters and special characters that conform to the standard ASCII character set. Line 1143: Line 1144: ISCSI_BOND_NOT_EXIST=Cannot ${action} ${type}. The specified iSCSI bond doesn't exist. Line 1145: ISCSI_BOND_WITH_SAME_NAME_EXIST_IN_DATA_CENTER=Cannot ${action} ${type}. iSCSI bond with the same name already exists in the Data Center. Line 1146: ISCSI_BOND_NOT_SUPPORTED=Cannot ${action} ${type}. iSCSI Bond is only supported on Data Center compatibility version 3.4 and higher. > s/version/versions Done Line 1147: -- To view, visit http://gerrit.ovirt.org/26931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d0ac7e6af6cb87b500740d679af2f13e63dbeb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
