Sergey Gotliv has posted comments on this change.

Change subject: core: Connect Storage Pool on iSCSI update
......................................................................


Patch Set 4:

Just to make myself clear. According to the commit message this patch:

"There is no need to throw an exception when calling
ConnectStorageServer since we should try to connect all the hosts, and if one 
of them fails we should keep try to connect all the other hosts."

But it contains a hidden change - its connecting all hosts to targets in the 
SINGLE THREAD now.

1. This change is not related to the bug and fix.
2. This is not documented in the commit message.

-- 
To view, visit http://gerrit.ovirt.org/27359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b125471920792d8bfaae2327e6aa757c378ef0e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to