Sergey Gotliv has uploaded a new change for review. Change subject: engine: Send ifaceName and tpgt in connectStorageServer ......................................................................
engine: Send ifaceName and tpgt in connectStorageServer Engine mistakenly sent initiatorName instead of ifaceName which overwrote existing initiatorName configured in the host. Wrong initiatorName caused host fail to perform iSCSI connection. In case of tpgt the problem is terminology. Engine sent it as a "portal" and its value was always 1, but from the iSCSI perspective portal is an access point to one or more targets, while this "1" is a tpgt - target portal group tag which is numeric representation of which IP addresses a target is allowed to bind on. Bug-Url: https://bugzilla.redhat.com/1078137 Change-Id: Ife467feb8aad9711da5d6a5df305e50fe6bf51e9 Signed-off-by: Sergey Gotliv <sgot...@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/25890/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java index 2ed19f1..9fb6594 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java @@ -73,12 +73,12 @@ DefaultValueMap con = new DefaultValueMap(); con.put("id", connection.getid(), Guid.Empty.toString()); con.put("connection", connection.getconnection(), ""); - con.put("portal", connection.getportal(), ""); + con.put("tpgt", connection.getportal(), ""); con.put("port", connection.getport(), ""); con.put("iqn", connection.getiqn(), ""); con.put("user", connection.getuser_name(), ""); con.put("password", connection.getpassword(), ""); - con.putIfNotEmpty("initiatorName", connection.getIface()); + con.putIfNotEmpty("ifaceName", connection.getIface()); // storage_pool can be null when discovering iscsi send targets or when connecting // through vds which has no storage pool -- To view, visit http://gerrit.ovirt.org/25890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ife467feb8aad9711da5d6a5df305e50fe6bf51e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
