[Engine-patches] Change in ovirt-engine[master]: aaa: Add Bearer and Negotiate auth filters

2015-06-16 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add Bearer and Negotiate auth filters .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/42292/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engi

[Engine-patches] Change in ovirt-engine[master]: aaa: Add Bearer and Negotiate auth filters

2015-06-16 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add Bearer and Negotiate auth filters .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/42292/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engi

[Engine-patches] Change in ovirt-engine[master]: aaa: Add Bearer and Negotiate auth filters

2015-06-16 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add Bearer and Negotiate auth filters .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/42292/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engi

[Engine-patches] Change in ovirt-engine[master]: aaa: Add Bearer and Negotiate auth filters

2015-06-16 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add Bearer and Negotiate auth filters .. Patch Set 3: (9 comments) https://gerrit.ovirt.org/#/c/42292/3/backend/manager/modules/aaa/src/main/java/org/ovirt/eng

[Engine-patches] Change in ovirt-engine[master]: aaa: Add Bearer and Negotiate auth filters

2015-06-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add Bearer and Negotiate auth filters .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42292/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engi

[Engine-patches] Change in ovirt-engine[master]: aaa: Add Bearer and Negotiate auth filters

2015-06-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add Bearer and Negotiate auth filters .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42292/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engi

[Engine-patches] Change in ovirt-engine[master]: aaa: Add Bearer and Negotiate auth filters

2015-06-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add Bearer and Negotiate auth filters .. Patch Set 3: Working on removing OVIRT-INTERNAL-ENGINE-AUTH-TOKEN in restapi -- To view, visit https://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: aaa: Add Bearer and Negotiate auth filters

2015-06-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add Bearer and Negotiate auth filters .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/42292/1/backend/manager/modules/aaa/src/main/java/org/ovirt/eng

[Engine-patches] Change in ovirt-engine[master]: uutil: crypto: EnvelopeEncryptDecrypt initial implementation

2015-06-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: uutil: crypto: EnvelopeEncryptDecrypt initial implementation .. Patch Set 2: Verified+1 Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42330 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: uutil: crypto: EnvelopeEncryptDecrypt initial implementation

2015-06-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: uutil: crypto: EnvelopeEncryptDecrypt initial implementation .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42330/1/backend/manager/modules/uutils/src/mai

[Engine-patches] Change in ovirt-engine[master]: uutil: crypto: EnvelopeEncryptDecrypt initial implementation

2015-06-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: uutil: crypto: EnvelopeEncryptDecrypt initial implementation .. Patch Set 1: Code-Review+1 (1 comment) Minor comment https://gerrit.ovirt.org/#/c/42330/1/backend/m

[Engine-patches] Change in ovirt-engine[master]: uutil: crypto: EnvelopeEncryptDecrypt initial implementation

2015-06-15 Thread rnori
Ravi Nori has posted comments on this change. Change subject: uutil: crypto: EnvelopeEncryptDecrypt initial implementation .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/42330 To unsubscribe, visit https

[Engine-patches] Change in ovirt-engine[master]: aaa: Add Bearer and Negotiate auth filters

2015-06-12 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add Bearer and Negotiate auth filters .. Patch Set 1: do not review -- To view, visit https://gerrit.ovirt.org/42292 To unsubscribe, visit https://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: aaa: Encrypt password returned to user, add support for Logi...

2015-06-12 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Encrypt password returned to user, add support for Login On Behalf .. Patch Set 1: do not review -- To view, visit https://gerrit.ovirt.org/42291 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: aaa: Encrypt password returned to user, add support for Logi...

2015-06-12 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: aaa: Encrypt password returned to user, add support for Login On Behalf .. aaa: Encrypt password returned to user, add support for Login On Behalf Will be merged t

[Engine-patches] Change in ovirt-engine[master]: aaa: Add Bearer and Negotiate auth filters

2015-06-12 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: aaa: Add Bearer and Negotiate auth filters .. aaa: Add Bearer and Negotiate auth filters This will be merged to patch #2 Change-Id: Idee5137430cefa7ca99c047cfd2d55

[Engine-patches] Change in ovirt-engine[master]: core: CommandBase - avoid inserting placeholders for dc with...

2015-06-11 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: CommandBase - avoid inserting placeholders for dc without spm .. Patch Set 6: -Code-Review -- To view, visit https://gerrit.ovirt.org/41691 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-06-08 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 71: (5 comments) https://gerrit.ovirt.org/#/c/36119/71/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/s

[Engine-patches] Change in ovirt-engine[master]: CommandBase - persist command if the parent command has a ca...

2015-06-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: CommandBase - persist command if the parent command has a callback .. Patch Set 2: the problem is the code is executed for all cases with out any check. This code

[Engine-patches] Change in ovirt-engine[master]: aaa: Modify webadmin and userportal to use enginesso for aut...

2015-06-02 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Modify webadmin and userportal to use enginesso for authentication .. Patch Set 54: Verified+1 -- To view, visit https://gerrit.ovirt.org/36619 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: aaa: Modify welcome screen to show user name and options as ...

2015-06-02 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Modify welcome screen to show user name and options as menu .. Patch Set 29: Verified+1 -- To view, visit https://gerrit.ovirt.org/40672 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-06-02 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 67: Verified+1 -- To view, visit https://gerrit.ovirt.org/36119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-Me

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-06-02 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 65: (11 comments) https://gerrit.ovirt.org/#/c/36119/65/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/

[Engine-patches] Change in ovirt-engine[master]: core: CommandBase - end job after execution only if there is...

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: CommandBase - end job after execution only if there is no callback .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41693 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: adding EntityPollingCommand/EntitiesPollingCallback

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: adding EntityPollingCommand/EntitiesPollingCallback .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40244 To unsubscribe, visit https

[Engine-patches] Change in ovirt-engine[master]: core: adding support for serial child commands execution

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: adding support for serial child commands execution .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40243 To unsubscribe, visit https:

[Engine-patches] Change in ovirt-engine[master]: core: adding ConcurrentChildCommandsExecutionCallback

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: adding ConcurrentChildCommandsExecutionCallback .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39117 To unsubscribe, visit https://g

[Engine-patches] Change in ovirt-engine[master]: core: CommandBase - adding noAsyncOperations()

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: CommandBase - adding noAsyncOperations() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41694 To unsubscribe, visit https://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: CoCoAsyncTaskHelper: do not clear command if the parent has ...

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: CoCoAsyncTaskHelper: do not clear command if the parent has callback .. Patch Set 1: Code-Review+1 Again please verify backward compatibility using LiveMerge -- T

[Engine-patches] Change in ovirt-engine[master]: core: VdcActionParametersBase - choose if command is ended b...

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: VdcActionParametersBase - choose if command is ended by parent .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41689 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: VdcActionParametersBase - adding VdsRunningOn member

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: VdcActionParametersBase - adding VdsRunningOn member .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41688 To unsubscribe, visit https://ge

[Engine-patches] Change in ovirt-engine[master]: core: CommandBase - obtain child commands on endAction()

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: CommandBase - obtain child commands on endAction() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41690 To unsubscribe, visit https:

[Engine-patches] Change in ovirt-engine[master]: core: CommandBase - avoid inserting placeholders for dc with...

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: CommandBase - avoid inserting placeholders for dc without spm .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41691 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: CommandBase - persist command if the parent command has a ca...

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: CommandBase - persist command if the parent command has a callback .. Patch Set 1: What is the scenario in which this is needed? If parent executes child using CoC

[Engine-patches] Change in ovirt-engine[master]: CommandExecutor - pass context to executed commands

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: CommandExecutor - pass context to executed commands .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41697 To unsubscribe, visit https://ger

[Engine-patches] Change in ovirt-engine[master]: core: CommandBase - avoid releasing lock if there is a callback

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: CommandBase - avoid releasing lock if there is a callback .. Patch Set 1: Code-Review+1 Please verify LiveMerge -- To view, visit https://gerrit.ovirt.org/41

[Engine-patches] Change in ovirt-engine[master]: core: adding support for serial child commands execution

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: adding support for serial child commands execution .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41699 To unsubscribe, visit https:

[Engine-patches] Change in ovirt-engine[master]: core: adding ConcurrentChildCommandsExecutionCallback

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: adding ConcurrentChildCommandsExecutionCallback .. Patch Set 1: Code-Review+1 Please send an email to Oved and me about the Infra bug for endWithFailure -- T

[Engine-patches] Change in ovirt-engine[master]: core: adding EntityPollingCommand/EntitiesPollingCallback

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: adding EntityPollingCommand/EntitiesPollingCallback .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41700 To unsubscribe, visit https

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 62: (20 comments) https://gerrit.ovirt.org/#/c/36119/62//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-05-28 13:20:25 -0400

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-06-01 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 63: Some questions on how to use token as key -- To view, visit https://gerrit.ovirt.org/36119 To unsubscribe, visit https://gerr

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Dismissible events

2015-05-28 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core, webadmin: Dismissible events .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41382 To unsubscribe, visit https://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Dismissible events

2015-05-28 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core, webadmin: Dismissible events .. Patch Set 5: Verified+1 Nice!!! -- To view, visit https://gerrit.ovirt.org/41382 To unsubscribe, visit https://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: addHost form leaves json checkbox locked when swit...

2015-05-26 Thread rnori
Ravi Nori has posted comments on this change. Change subject: webadmin: addHost form leaves json checkbox locked when switching between clusters .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/41485 To u

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: addHost form leaves json checkbox locked when swit...

2015-05-26 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: webadmin: addHost form leaves json checkbox locked when switching between clusters .. webadmin: addHost form leaves json checkbox locked when switching between clu

[Engine-patches] Change in ovirt-engine[master]: core : Active users query returns 'bad sql grammer' error

2015-05-26 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core : Active users query returns 'bad sql grammer' error .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/39844 To unsubscribe, visit https://

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Dismissible events

2015-05-26 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core, webadmin: Dismissible events .. Patch Set 3: (1 comment) Fix logic to reduce db calls https://gerrit.ovirt.org/#/c/41382/3/backend/manager/modules/bll/src/ma

[Engine-patches] Change in ovirt-engine[master]: webadmin: addHost form leaves json checkbox locked when swit...

2015-05-26 Thread rnori
Ravi Nori has posted comments on this change. Change subject: webadmin: addHost form leaves json checkbox locked when switching between clusters .. Patch Set 4: Verified+1 @Alexander Handled all comments -- To view, visit h

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-05-22 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 59: (2 comments) https://gerrit.ovirt.org/#/c/36119/59/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/s

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-05-22 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 59: (9 comments) https://gerrit.ovirt.org/#/c/36119/59/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/s

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-05-22 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 56: (1 comment) https://gerrit.ovirt.org/#/c/36119/56/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/se

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-05-20 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 56: (25 comments) https://gerrit.ovirt.org/#/c/36119/56/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/

[Engine-patches] Change in ovirt-engine[master]: webadmin: addHost form leaves json checkbox locked when swit...

2015-05-20 Thread rnori
Ravi Nori has posted comments on this change. Change subject: webadmin: addHost form leaves json checkbox locked when switching between clusters .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41122/2/frontend/webadm

[Engine-patches] Change in ovirt-engine[master]: webadmin: addHost form leaves json checkbox locked when swit...

2015-05-19 Thread rnori
Ravi Nori has posted comments on this change. Change subject: webadmin: addHost form leaves json checkbox locked when switching between clusters .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/41122 To u

[Engine-patches] Change in ovirt-engine[master]: webadmin: addHost form leaves json checkbox locked when swit...

2015-05-19 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: webadmin: addHost form leaves json checkbox locked when switching between clusters .. webadmin: addHost form leaves json checkbox locked when switching between clu

[Engine-patches] Change in ovirt-engine[master]: vdsbroker: async vdscommand

2015-05-13 Thread rnori
Ravi Nori has posted comments on this change. Change subject: vdsbroker: async vdscommand .. Patch Set 15: Verified+1 -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: wip, engine : Remove Disk command using getVolumeInfo

2015-05-13 Thread rnori
Ravi Nori has posted comments on this change. Change subject: wip, engine : Remove Disk command using getVolumeInfo .. Patch Set 15: Verified+1 -- To view, visit https://gerrit.ovirt.org/39374 To unsubscribe, visit https://ger

[Engine-patches] Change in ovirt-engine[master]: engine : Add json rpc request completed method

2015-05-13 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : Add json rpc request completed method .. Patch Set 16: Verified+1 -- To view, visit https://gerrit.ovirt.org/39373 To unsubscribe, visit https://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: wip, engine : Remove Disk command using getVolumeInfo

2015-05-12 Thread rnori
Ravi Nori has posted comments on this change. Change subject: wip, engine : Remove Disk command using getVolumeInfo .. Patch Set 12: Verified-1 I tried deleting a 32 GB disk and runAsyncVdsCommand in RemoveImageCommandCallback

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-05-11 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 49: (2 comments) https://gerrit.ovirt.org/#/c/36119/49/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/s

[Engine-patches] Change in ovirt-engine[master]: engine : Make StatusReturnForXmlRpc.mStatus private

2015-05-11 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : Make StatusReturnForXmlRpc.mStatus private .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/39399 To unsubscribe, visit https://gerrit

[Engine-patches] Change in ovirt-engine[master]: engine : Add json rpc request completed method

2015-05-11 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : Add json rpc request completed method .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/39373 To unsubscribe, visit https://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: vdsbroker: async vdscommand

2015-05-11 Thread rnori
Ravi Nori has posted comments on this change. Change subject: vdsbroker: async vdscommand .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: vdsbroker: async vdscommand

2015-05-11 Thread rnori
Ravi Nori has posted comments on this change. Change subject: vdsbroker: async vdscommand .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: wip, engine : Remove Disk command using getVolumeInfo

2015-05-11 Thread rnori
Ravi Nori has posted comments on this change. Change subject: wip, engine : Remove Disk command using getVolumeInfo .. Patch Set 6: Verified+1 Verified both xml and json rpc -- To view, visit https://gerrit.ovirt.org/39374 To

[Engine-patches] Change in ovirt-engine[master]: wip, engine : Remove Disk command using getVolumeInfo

2015-05-11 Thread rnori
Ravi Nori has posted comments on this change. Change subject: wip, engine : Remove Disk command using getVolumeInfo .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/39374/5/backend/manager/modules/bll/src/main/java/or

[Engine-patches] Change in ovirt-engine[master]: aaa: Modify welcome screen to show user name and options as ...

2015-05-08 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Modify welcome screen to show user name and options as menu .. Patch Set 6: Yes it is but I did not add debug messages yet, will do it -- To view, visit https

[Engine-patches] Change in ovirt-engine[master]: aaa: Modify welcome screen to show user name and options as ...

2015-05-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Modify welcome screen to show user name and options as menu .. Patch Set 5: will address comments -- To view, visit https://gerrit.ovirt.org/40672 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: aaa: Modify welcome screen to show user name and options as ...

2015-05-07 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: aaa: Modify welcome screen to show user name and options as menu .. aaa: Modify welcome screen to show user name and options as menu Adds menu to welcome screen. W

[Engine-patches] Change in ovirt-engine[master]: engine: Add Upgrade host command

2015-05-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine: Add Upgrade host command .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40462/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bl

[Engine-patches] Change in ovirt-engine[master]: core: adding ConcurrentChildCommandsExecutionCallback

2015-05-06 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: adding ConcurrentChildCommandsExecutionCallback .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39117 To unsubscribe, visit https://g

[Engine-patches] Change in ovirt-engine[master]: core: adding support for serial child commands execution

2015-05-06 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: adding support for serial child commands execution .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40243 To unsubscribe, visit https:

[Engine-patches] Change in ovirt-engine[master]: core: adding EntityPollingCommand/EntitiesPollingCallback

2015-05-06 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: adding EntityPollingCommand/EntitiesPollingCallback .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40244 To unsubscribe, visit https

[Engine-patches] Change in ovirt-engine[master]: engine: Add Upgrade host command

2015-05-06 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine: Add Upgrade host command .. Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/40462/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/b

[Engine-patches] Change in ovirt-engine[master]: aaa: Remove basic auth and negotiate aaa filters

2015-05-06 Thread rnori
Ravi Nori has abandoned this change. Change subject: aaa: Remove basic auth and negotiate aaa filters .. Abandoned Squashed -- To view, visit https://gerrit.ovirt.org/40108 To unsubscribe, visit https://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: aaa: Redirect login to login.html and save profile selection...

2015-05-06 Thread rnori
Ravi Nori has abandoned this change. Change subject: aaa: Redirect login to login.html and save profile selection in cookie .. Abandoned Squashed -- To view, visit https://gerrit.ovirt.org/39833 To unsubscribe, visit https:/

[Engine-patches] Change in ovirt-engine[master]: aaa: Introduce sso query service

2015-05-06 Thread rnori
Ravi Nori has abandoned this change. Change subject: aaa: Introduce sso query service .. Abandoned Squashed -- To view, visit https://gerrit.ovirt.org/38499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-Mess

[Engine-patches] Change in ovirt-engine[master]: aaa: Rework webadmin login sequence

2015-05-06 Thread rnori
Ravi Nori has abandoned this change. Change subject: aaa: Rework webadmin login sequence .. Abandoned Squashed -- To view, visit https://gerrit.ovirt.org/38212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-M

[Engine-patches] Change in ovirt-engine[master]: aaa: Add ability to switch user

2015-05-06 Thread rnori
Ravi Nori has abandoned this change. Change subject: aaa: Add ability to switch user .. Abandoned Squashed -- To view, visit https://gerrit.ovirt.org/38146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-Messa

[Engine-patches] Change in ovirt-engine[master]: aaa: Engine session validation should be done against sso

2015-05-06 Thread rnori
Ravi Nori has abandoned this change. Change subject: aaa: Engine session validation should be done against sso .. Abandoned Squashed -- To view, visit https://gerrit.ovirt.org/38015 To unsubscribe, visit https://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: aaa: Add SSO Session validation service

2015-05-06 Thread rnori
Ravi Nori has abandoned this change. Change subject: aaa: Add SSO Session validation service .. Abandoned Squashed -- To view, visit https://gerrit.ovirt.org/38011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerr

[Engine-patches] Change in ovirt-engine[master]: aaa: Add support for rest api Basic auth

2015-05-06 Thread rnori
Ravi Nori has abandoned this change. Change subject: aaa: Add support for rest api Basic auth .. Abandoned Squashed -- To view, visit https://gerrit.ovirt.org/37786 To unsubscribe, visit https://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: aaa: add support for basic and external authentication

2015-05-06 Thread rnori
Ravi Nori has abandoned this change. Change subject: aaa: add support for basic and external authentication .. Abandoned Squashed -- To view, visit https://gerrit.ovirt.org/37299 To unsubscribe, visit https://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: aaa: Add ability to switch user

2015-05-06 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add ability to switch user .. Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/38146/10/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine

[Engine-patches] Change in ovirt-engine[master]: aaa: Engine session validation should be done against sso

2015-05-06 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Engine session validation should be done against sso .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/38015/7/backend/manager/modules/aaa/src/main/java

[Engine-patches] Change in ovirt-engine[master]: aaa: Add support for rest api Basic auth

2015-05-06 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Add support for rest api Basic auth .. Patch Set 10: (3 comments) https://gerrit.ovirt.org/#/c/37786/10/backend/manager/modules/aaa/src/main/java/org/ovirt/eng

[Engine-patches] Change in ovirt-engine[master]: core : Add Entity API for CoCo commands

2015-05-05 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core : Add Entity API for CoCo commands .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/37463 To unsubscribe, visit https://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core : Add Entity API for CoCo commands

2015-05-05 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core : Add Entity API for CoCo commands .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/37463 To unsubscribe, visit https://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: core : Add Entity API for CoCo commands

2015-05-05 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core : Add Entity API for CoCo commands .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/37463/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/

[Engine-patches] Change in ovirt-engine[master]: core : Add Entity API for CoCo commands

2015-05-05 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core : Add Entity API for CoCo commands .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/37463/8/packaging/dbscripts/upgrade/03_06_1340_add_cmd_associated_e

[Engine-patches] Change in ovirt-engine[master]: aaa : Add engine sso

2015-05-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso .. Patch Set 43: (1 comment) Will remove the whole config package. Too much complexity for what it does. https://gerrit.ovirt.org/#/c/36119/43

[Engine-patches] Change in ovirt-engine[master]: aaa: Modify webadmin and userportal to use enginesso for aut...

2015-05-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Modify webadmin and userportal to use enginesso for authentication .. Patch Set 30: (1 comment) https://gerrit.ovirt.org/#/c/36619/30/packaging/services/ovirt

[Engine-patches] Change in ovirt-engine[master]: aaa: Modify webadmin and userportal to use enginesso for aut...

2015-05-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: aaa: Modify webadmin and userportal to use enginesso for authentication .. Patch Set 30: (3 comments) https://gerrit.ovirt.org/#/c/36619/30/backend/manager/modules

[Engine-patches] Change in ovirt-engine[master]: core : Add Entity API for CoCo commands

2015-05-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core : Add Entity API for CoCo commands .. Patch Set 6: (11 comments) https://gerrit.ovirt.org/#/c/37463/6/backend/manager/modules/common/src/main/java/org/ovirt/en

[Engine-patches] Change in ovirt-engine[master]: core : Add Entity API for CoCo commands

2015-05-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core : Add Entity API for CoCo commands .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/37463/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine

[Engine-patches] Change in ovirt-engine[master]: core : Add Entity API for CoCo commands

2015-05-04 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core : Add Entity API for CoCo commands .. Patch Set 6: (3 comments) @Moti We renamed JobSubjectEntity to SubjectEntity. should JobSubjectEntityDaoFacadeImpl be r

[Engine-patches] Change in ovirt-engine[master]: aaa: Add SSO UI for Changing expired user passwd

2015-04-30 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: aaa: Add SSO UI for Changing expired user passwd .. aaa: Add SSO UI for Changing expired user passwd Add Change Password page and sso service to handle the request.

[Engine-patches] Change in ovirt-engine[master]: webadmin: GuideMe can't activate hosts

2015-04-30 Thread rnori
Ravi Nori has posted comments on this change. Change subject: webadmin: GuideMe can't activate hosts .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/39992 To unsubscribe, visit https://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: Fix errors for retry of failed DestroyImageCommand

2015-04-30 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: Fix errors for retry of failed DestroyImageCommand .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40228 To unsubscribe, visit https:

[Engine-patches] Change in ovirt-engine[master]: core: CommandBase - obtain child commands on endAction()

2015-04-29 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: CommandBase - obtain child commands on endAction() .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40246/2/backend/manager/modules/bll/src/main/java/

  1   2   3   4   5   6   7   8   9   10   >