Ravi Nori has posted comments on this change. Change subject: aaa : Add engine sso ......................................................................
Patch Set 43: (1 comment) Will remove the whole config package. Too much complexity for what it does. https://gerrit.ovirt.org/#/c/36119/43/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOContextListener.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOContextListener.java: Line 42: config.setSsoProfiles(AuthenticationUtils.getAvailableProfiles(ctx)); Line 43: config.setWelcomeUrl(localConfig.getProperty(WELCOME_URL)); Line 44: ctx.setAttribute(SSOUtils.SSO_CONFIG, config); Line 45: try { Line 46: ctx.setAttribute(SSOUtils.SSO_TICKET_ENCODER, getTicketEncoder(ctx, localConfig, Integer.parseInt(localConfig.getProperty(TICKET_LIFETIME)))); > I am unsure we need the ticket encoder any more will remove Line 47: } catch (Exception e) { Line 48: throw new RuntimeException("Unable to instantiate TicketEncoder", e); Line 49: } Line 50: } -- To view, visit https://gerrit.ovirt.org/36119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 43 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
