Ravi Nori has posted comments on this change.

Change subject: webadmin: addHost form leaves json checkbox locked when 
switching between clusters
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/41122/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java:

Line 865:                         }
Line 866:                     }));
Line 867:                 }
Line 868: 
Line 869:                 
hostModel.getCluster().getSelectedItemChangedEvent().addListener(new 
IEventListener<EventArgs>() {
> Any particular reason this isn't in the 'cluster_SelectedItemChanged' in Ho
This is the edit host command, so I added to edit method. Is there another 
place I can add this?
Line 870: 
Line 871:                     @Override
Line 872:                     public void eventRaised(Event<? extends 
EventArgs> ev, Object sender, EventArgs args) {
Line 873:                         ListModel<VDSGroup> clusterModel = 
hostModel.getCluster();


-- 
To view, visit https://gerrit.ovirt.org/41122
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38bfe657750819a772a97251f3cee93cc2de9d76
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to