Ravi Nori has posted comments on this change. Change subject: core, webadmin: Dismissible events ......................................................................
Patch Set 3: (1 comment) Fix logic to reduce db calls https://gerrit.ovirt.org/#/c/41382/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearDismissedAuditLogsBySeverityCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearDismissedAuditLogsBySeverityCommand.java: Line 25: } Line 26: Line 27: @Override Line 28: protected void executeCommand() { Line 29: for (AuditLogSeverity severity : getParameters().getSeverities()) { clearing audit logs is now going to take 4 calls to DB instead of one. I would suggest adding a new command just for this patch. or fix the logic to not make 4 calls to db. Line 30: DbFacade.getInstance().getAuditLogDao().clearDismissedBySeverity(severity); Line 31: } Line 32: setSucceeded(true); Line 33: } -- To view, visit https://gerrit.ovirt.org/41382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibae6686f24dcf6afc1fb0db48d803176dd318d88 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
