Ravi Nori has posted comments on this change. Change subject: uutil: crypto: EnvelopeEncryptDecrypt initial implementation ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42330/1/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/EnvelopeEncryptDecrypt.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/EnvelopeEncryptDecrypt.java: Line 21: import org.codehaus.jackson.map.ObjectMapper; Line 22: import org.codehaus.jackson.map.type.TypeFactory; Line 23: Line 24: public class EnvelopeEncryptDecrypt { Line 25: > I tried to think like "java developer", and define a constant per variable :) I dont mind the style. Line 26: private static final String PUBKEY_DIGEST_ALGO = "SHA-1"; Line 27: private static final String PKEY_MODE_PADDING = "ECB/PKCS1Padding"; Line 28: Line 29: private static final String CONTENT_KEY = "content"; -- To view, visit https://gerrit.ovirt.org/42330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b7444ba279bbfaadd162dee4a552b434249aaac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches