Ravi Nori has posted comments on this change. Change subject: aaa: Modify webadmin and userportal to use enginesso for authentication ......................................................................
Patch Set 30: (3 comments) https://gerrit.ovirt.org/#/c/36619/30/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java: Line 68: queryRetVal.getActionReturnValue()); Line 69: response.sendRedirect(request.getParameter("opaque")); Line 70: } Line 71: } catch (Exception ex) { Line 72: log.error("Exception creating user session {}", ex.getMessage()); > this is user visible error... something like: Done Line 73: throw new RuntimeException("Exception creating user session", ex); Line 74: } finally { Line 75: try { Line 76: if (ctx != null) { https://gerrit.ovirt.org/#/c/36619/30/backend/manager/modules/welcome/src/main/resources/messages.properties File backend/manager/modules/welcome/src/main/resources/messages.properties: Line 7: #reports not installed error page Line 8: reportsnotinstalled.reports_not_installed=Reports not installed Line 9: reportsnotinstalled.link=Click here to continue. Line 10: #error page with message Line 11: errorpage.link=Click here to continue. > please make sure you have new lines Done https://gerrit.ovirt.org/#/c/36619/30/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 258: Line 259: # Line 260: # Error page Line 261: # Line 262: ERROR_PAGE=/ovirt-engine/error.html > won't it better to be relative to ovirt-engine (application root?) Changed it to ERROR_PAGE=${ENGINE_URI}/error.html Not sure about customization Line 263: Line 264: # Line 265: # Disable extensions (override extension configuration) Line 266: # -- To view, visit https://gerrit.ovirt.org/36619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff0aee9d0f5ee606ff7f397cab69017ca7d9df08 Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
