Ravi Nori has posted comments on this change. Change subject: core: CommandBase - obtain child commands on endAction() ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40246/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 583: Line 584: commandBase.getParameters().setImagesParameters(parameters); Line 585: } Line 586: } Line 587: I do not understand what is going on in here. Can you please elaborate Line 588: protected boolean isEndSuccessfully() { Line 589: return getParameters().getTaskGroupSuccess() Line 590: && getParameters().getExecutionReason() == CommandExecutionReason.REGULAR_FLOW; Line 591: } -- To view, visit https://gerrit.ovirt.org/40246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa4c4e4d60508161d69a9f8c4d7a75ec00737e7f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
