Einav Cohen has posted comments on this change.
Change subject: reset page to 1 on sort
..
Patch Set 1:
> I don't see this as much of a risk at all. Should be good to backport.
thanks.
--
To view, visit https://gerrit.ovirt.
Einav Cohen has posted comments on this change.
Change subject: reset page to 1 on sort
..
Patch Set 1:
@Alexander, this is a backport of your patch
https://gerrit.ovirt.org/#/c/36084.
Please advise whether or not this is a
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin, userportal: translations update
..
webadmin, userportal: translations update
pulled translation from Zanata oVirt project, master version.
Chan
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42213
To unsubscribe, visit https://gerrit.ovirt.o
Einav Cohen has uploaded a new change for review.
Change subject: webadmin, userportal: translations update
..
webadmin, userportal: translations update
pulled translation from Zanata oVirt project, master version.
Change-Id: I
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: new VM cluster combo
..
Patch Set 1:
@Tomas - would be great if you can review as well.
Please note that a similar change was done in the Ne
Einav Cohen has posted comments on this change.
Change subject: webadmin: fence agents ui
..
Patch Set 15:
@Eli/Martin: Any chance that you can apply this patch and test the feature
end-to-end?
Thanks!
--
To view, visit htt
Einav Cohen has posted comments on this change.
Change subject: webadmin: cluster guide me datacenter
..
Patch Set 1:
@Alexander - need to add reviewers? or too early?
--
To view, visit https://gerrit.ovirt.org/41486
To unsub
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: fix IE8 rendering / jquery failure
..
Patch Set 1:
@Greg: abandon this patch and require PatternFly v1.2.0 instead?
--
To view, visit https
Einav Cohen has posted comments on this change.
Change subject: engine, webadmin: Corrected action and type values
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40899
To unsubscribe, visit https://ge
Einav Cohen has posted comments on this change.
Change subject: engine, webadmin: Corrected action and type values
..
Patch Set 1:
please rebase now that https://gerrit.ovirt.org/#/c/40887 is merged (I expect
there would be a
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin, userportal: unnecessary quotation marks
..
webadmin, userportal: unnecessary quotation marks
Removed unnecessary double quotation marks from a c
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: unnecessary quotation marks
..
Patch Set 1: Verified+1
@Tomas/Shubhendu - recommending to review (this patch removes double quotation
marks
Einav Cohen has uploaded a new change for review.
Change subject: webadmin, userportal: unnecessary quotation marks
..
webadmin, userportal: unnecessary quotation marks
Removed unnecessary double quotation marks from a couple of
Einav Cohen has posted comments on this change.
Change subject: webadmin: fence agents ui
..
Patch Set 7:
Alexander - need to add reviewers? or is this still WIP?
--
To view, visit https://gerrit.ovirt.org/40627
To unsubscrib
Einav Cohen has posted comments on this change.
Change subject: Revert "webadmin: cluster guide me datacenter"
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40821
To unsubscribe, visit https://gerrit
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin, userportal: translations update (de-DE only)
..
webadmin, userportal: translations update (de-DE only)
pulled German translation from Zanata oVi
Einav Cohen has posted comments on this change.
Change subject: webadmin: UI plugins - control tab priority
..
Patch Set 1:
Hi Kanagaraj, can you please verify this patch? thanks.
--
To view, visit https://gerrit.ovirt.org/40
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update (de-DE only)
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40015
To unsubscribe, visit https://g
Einav Cohen has uploaded a new change for review.
Change subject: webadmin, userportal: translations update (de-DE only)
..
webadmin, userportal: translations update (de-DE only)
pulled German translation from Zanata oVirt proje
Einav Cohen has posted comments on this change.
Change subject: webadmin: Fix System tree when in Gluster-only mode
..
Patch Set 7:
Thanks Anmol and Greg.
> I believe that in 'both' mode, Datacenter will show up and look norma
Einav Cohen has posted comments on this change.
Change subject: webadmin: revert 65452f9dedea24d0acaa38177a987727a79bb7aa
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39456
To unsubscribe, visit htt
Einav Cohen has posted comments on this change.
Change subject: webadmin: Fix System tree when in Gluster-only mode
..
Patch Set 7:
Thanks for posting the screen-shots, Anmol - much appreciated.
A couple of clarifications (an
Einav Cohen has posted comments on this change.
Change subject: webadmin : Fix Gluster only mode System tree This patch adds
Hosts and Volumes nodes needed in Gluster-only mode to the System tree root.
Previously only System and Sessions were shown in Gluster-only mode (because
there is no data
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: multiple login messages
..
Patch Set 3:
> With icons and changed link colors:
> http://imgur.com/kqQzA3a
> http://imgur.com/J5DCb3x
Looks a
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: multiple login messages
..
Patch Set 2:
> We went with red on the links because the blue was designed to be
> on a white background.
>
> B
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: multiple login messages
..
Patch Set 2:
> For greg some images:
> RHEV:
> http://imgur.com/9ULWaxj
> http://imgur.com/92hz6D4
> Ovirt:
>
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: convert all grids (Cells) to PatternFly
tooltips
..
Patch Set 25:
(1 comment)
https://gerrit.ovirt.org/#/c/37935/25/frontend/webadmin/modul
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: convert remaining widgets to PatternFly
tooltips
..
Patch Set 14:
re-tested with updated patches:
> 1. There are no tool-tips on cropped
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: fix findbugs questionable cast
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38810
To unsubscribe, visit https://
Einav Cohen has submitted this change and it was merged.
Change subject: userportal, webadmin: fix findbugs questionable cast
..
userportal, webadmin: fix findbugs questionable cast
Commit 5b50b18 introduced a findbugs error fo
Einav Cohen has posted comments on this change.
Change subject: added reference to oVirtDash sample portal
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38543
To unsubscribe, visit https://gerrit.ovi
Einav Cohen has posted comments on this change.
Change subject: webadmin: no auto logout when idle
..
Patch Set 4:
Oved - can you please take a look on the backend change? thanks in advance.
--
To view, visit https://gerrit.o
Einav Cohen has posted comments on this change.
Change subject: webadmin: Merged the status column with migration progress
..
Patch Set 2:
> Hey Greg, any chance you could give me +2? Or do you want me to ask
> also someone el
Einav Cohen has submitted this change and it was merged.
Change subject: added reference to oVirtDash sample portal
..
added reference to oVirtDash sample portal
Change-Id: I5c0e54652d89d811d24158153b336d82f0b8d0d3
Signed-off-b
Einav Cohen has posted comments on this change.
Change subject: webadmin: Add sessions main tab
..
Patch Set 4:
> here is the sceenshot http://imgur.com/LeyV5Cd
thanks Yevgeny, looks good - the icon of the 'Sessions' node in t
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: convert remaining widgets to PatternFly
tooltips
..
Patch Set 8:
Greg, here are a few issues that I have noticed; some may not be related to
Einav Cohen has submitted this change and it was merged.
Change subject: core: improved error message for duplicate NFS parameters
..
core: improved error message for duplicate NFS parameters
added "duplicate" to the error mess
Einav Cohen has posted comments on this change.
Change subject: core: improved error message for duplicate NFS parameters
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38452
To unsubscribe, visit htt
Einav Cohen has posted comments on this change.
Change subject: webadmin: no auto logout when idle
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/37837/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/cor
Einav Cohen has posted comments on this change.
Change subject: webadmin: Add sessions main tab
..
Patch Set 2:
Yevgeny, any chance that you can post a screen-shot?
--
To view, visit https://gerrit.ovirt.org/38384
To unsubscr
Einav Cohen has posted comments on this change.
Change subject: webadmin: cluster guide me datacenter
..
Patch Set 1:
@Derez/Gilad/Lior/Alona: Please take a look at Alexander's inline comment in
EntityModelCellTable.java - see
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: topologhy -> topology
..
webadmin: topologhy -> topology
Fixed typo in help icon ('?') tool-tip of 'Configure Numa' within the
Host section in t
Einav Cohen has uploaded a new change for review.
Change subject: webadmin: topologhy -> topology
..
webadmin: topologhy -> topology
Fixed typo in help icon ('?') tool-tip of 'Configure Numa' within the
Host section in the New V
Einav Cohen has posted comments on this change.
Change subject: webadmin: topologhy -> topology
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: permission dialog layout
..
Patch Set 4:
@Alexander/Greg: 'Connect Automatically' in the User Portal login page looks
kind of strange: http:/
Einav Cohen has posted comments on this change.
Change subject: webadmin : CheckBoxGroup, DaysOfMonthSelector and DateTimeBox
Widgets
..
Patch Set 4:
(1 comment)
@Greg, do we know if PatternFly has any date-time selection sol
Einav Cohen has posted comments on this change.
Change subject: webadmin : CheckBoxGroup, DaysOfMonthSelector and DateTimeBox
Widgets
..
Patch Set 3:
Hi Anmol, can you please post screen-shots of the new widgets that you are
Einav Cohen has posted comments on this change.
Change subject: restapi: Add CORS filter
..
Patch Set 5:
Thanks, Juan - I see that you added the relevant config values.
@Greg[/Jenny] - can you please test/verify?
--
To view
Einav Cohen has posted comments on this change.
Change subject: webadmin: Adapt UI plugin infra REST session timeout
..
Patch Set 3:
> http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/9605/ :
> FAILURE
unrel
Einav Cohen has posted comments on this change.
Change subject: webadmin: Adapt UI plugin infra REST session timeout
..
Patch Set 1:
Vojtech - once http://gerrit.ovirt.org/#/c/36737/ is merged - please verify
this patch and re
Einav Cohen has posted comments on this change.
Change subject: webadmin: Adapt UI plugin infra REST session timeout
..
Patch Set 2:
@Vojtech - merge?
--
To view, visit http://gerrit.ovirt.org/36737
To unsubscribe, visit http
Einav Cohen has posted comments on this change.
Change subject: webadmin: Adapt UI plugin infra REST session timeout
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/36738
To unsubscribe, visit http:
Einav Cohen has posted comments on this change.
Change subject: WIP: new Tooltip infrastructure
..
Patch Set 3:
@Greg - is this obsolete and should be abandoned? or are you planning on
refreshing it (maybe as 'Depending On' ht
Einav Cohen has posted comments on this change.
Change subject: webadmin: Adapt UI plugin infra REST session timeout
..
Patch Set 2:
> the GUI cannot control this exact timeout, let alone control it.
correction: the GUI cannot
Einav Cohen has posted comments on this change.
Change subject: webadmin: Adapt UI plugin infra REST session timeout
..
Patch Set 2:
Alon, the fact that the engine session ends before the rest-api-http-session is
indeed ok.
Einav Cohen has posted comments on this change.
Change subject: webadmin: Adapt UI plugin infra REST session timeout
..
Patch Set 2:
> see above comment, I am unsure why this patch is required.
the idea is to make sure that th
Einav Cohen has posted comments on this change.
Change subject: webadmin: Fix UI plugin REST API / Engine session refresh issue
..
Patch Set 6:
> http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_merged/1957/ :
> FAIL
Einav Cohen has posted comments on this change.
Change subject: webadmin: Fix UI plugin REST API / Engine session refresh issue
..
Patch Set 5:
> ... so the scenario you wrote above is not possible, I think.
consider the follo
Einav Cohen has posted comments on this change.
Change subject: webadmin: Fix UI plugin REST API / Engine session refresh issue
..
Patch Set 5:
> setting UserSessionTimeOutInterval=2 (2 mins). Chrome 36 logs me out in about
>
Einav Cohen has posted comments on this change.
Change subject: webadmin,userportal: Frontend improvements
..
Patch Set 1:
> I thought there are different keys at webadmin and userportal per what awels
> showed me once.
I ass
Einav Cohen has posted comments on this change.
Change subject: webadmin,userportal: Frontend improvements
..
Patch Set 1:
> Does above make sense?
it does, Vojtech - sounds good. thank you.
--
To view, visit http://gerrit.o
Einav Cohen has posted comments on this change.
Change subject: webadmin,userportal: Frontend improvements
..
Patch Set 1:
re: section 4 ("__" client storage key format):
- including the "version" part in the key is problemat
Einav Cohen has posted comments on this change.
Change subject: WIP: new Tooltip infrastructure
..
Patch Set 3:
> times are configurable. Fading in/out is by design. I think the current
> implementation where it instantly open
Einav Cohen has posted comments on this change.
Change subject: WIP: new Tooltip infrastructure
..
Patch Set 3:
> see https://raw.githubusercontent.com/eco-public/clipboard/master/out-6.ogv:
without the colon (':') at the end:
Einav Cohen has posted comments on this change.
Change subject: WIP: new Tooltip infrastructure
..
Patch Set 3:
see https://raw.githubusercontent.com/eco-public/clipboard/master/out-6.ogv:
the tool-tips themselves look great,
Einav Cohen has posted comments on this change.
Change subject: WIP: new Tooltip infrastructure
..
Patch Set 3:
> [missing '//$NON-NLS-1$' in AbstractTooltipCell.java, unused 'import's in
> AbstractTooltipCell.java]
correctio
Einav Cohen has posted comments on this change.
Change subject: WIP: new Tooltip infrastructure
..
Patch Set 3:
rebased; fixed a couple of checkstyle issues [missing '//$NON-NLS-1$' in
AbstractTooltipCell.java, unused 'import'
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: Replace UIConstants.empty()
..
Patch Set 1:
shouldn't all of the modified lines be with "//$NON-NLS-1$" or something
similar (to avoid check-
Einav Cohen has posted comments on this change.
Change subject: webadmin: new host->password
..
Patch Set 1: Code-Review+2
this changes non-English .properties strings - parallel changes will be made in
Zanata's oVirt project,
Einav Cohen has posted comments on this change.
Change subject: webadmin: new host->password
..
Patch Set 1: Code-Review+2
this changes non-English .properties strings - parallel changes will be made in
Zanata's oVirt project,
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update [it-IT]
..
Patch Set 3:
> Einav, there are many trailing white spaces.
> Is it possible to remove it?
the trailing whit
Einav Cohen has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 11:
Martin: please take a look at http://gerrit.ovirt.org/#/c/35185/ - even after
all of the changes in the way
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: Multi view table columns inconsistent
..
Patch Set 4:
> Looks good now :) Any chance to backport it to 3.5?
BZ is currently targeted for 3.6,
Einav Cohen has posted comments on this change.
Change subject: engine: don't read external files in unit test
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34678
To unsubscribe, visit http://gerrit.o
Einav Cohen has posted comments on this change.
Change subject: engine,userportal,webadmin: Event log->Event list/pane
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35147
To unsubscribe, visit http://
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: preserve grid scroll
..
Patch Set 2:
> @Vojtech, I believe Einav has some issues with the solution.
indeed, there are issues with the current
Einav Cohen has posted comments on this change.
Change subject: webadmin: Events tab message column too narrow
..
Patch Set 1:
thanks, Ravi. sounds good.
--
To view, visit http://gerrit.ovirt.org/34161
To unsubscribe, visit h
Einav Cohen has posted comments on this change.
Change subject: webadmin: Events tab message column too narrow
..
Patch Set 1:
Ravi, the Events tab has a "Basic Mode" view and an "Advanced Mode" view
(toggable via the radio-bu
Einav Cohen has posted comments on this change.
Change subject: Added more tests to ovirt.js
..
Patch Set 2:
in addition to addressing the inline comments, please make sure to rebase this
patch on top of the latest version of
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: preserve grid scroll
..
Patch Set 2:
> I can actually explain the scroll to ccc in FF
the scroll to cc in FF is OK, that is the desired behav
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: preserve grid scroll
..
Patch Set 2:
> sure - will apply and report in a bit.
update:
I have tested the following scenario in Chrome 38 and
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: preserve grid scroll
..
Patch Set 2:
> Ok. Doesn't appear to work in my Chrome. Maybe Einav can try?
sure - will apply and report in a bit.
Einav Cohen has posted comments on this change.
Change subject: restapi,userportal,webadmin: secure cookie
..
Patch Set 4:
> Need a +2 from someone, either Vojtech or Einav.
I prefer that Vojtech will provide that, just to mak
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: close button
..
Patch Set 1:
> Patch Set 1: Code-Review+1
@Vojtech - any reason for not granting "+2"?
--
To view, visit http://gerrit.ovir
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: Dialog box header drag
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33642
To unsubscribe, visit http://gerrit.ovi
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: Dialog box header drag
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33490
To unsubscribe, visit http:/
Einav Cohen has posted comments on this change.
Change subject: webadmin: Simplify report redirect
..
Patch Set 4:
@Yaniv/Shirly: this patch has been only partially verified (see Alexander's
comment right after posting patch s
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: Dialog box header drag
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/33490/1/frontend/webadmin/modules/gwt-common/src/main/resour
Einav Cohen has posted comments on this change.
Change subject: engine: introducing italian
..
Patch Set 3:
> kind of a bummer we gotta change 4 config files to do this :/
I believe that we have tried to improve this a while a
Einav Cohen has posted comments on this change.
Change subject: webadmin,userportal: Persistent client-side logging
infrastructure
..
Patch Set 1:
Vojtech - is this something that we can/should push forward?
--
To view, visi
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: remove FF17, add FF31 to supported
browsers
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33288
To unsubscribe, v
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: remove FF17, add FF31 to supported
browsers
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33291
To unsubscribe, v
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: remove FF17, add FF31 to supported
browsers
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33288/1//COMMIT_MSG
Commit Message:
Li
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: remove FF17, add FF31 to supported
browsers
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33280
To unsubscribe, v
Einav Cohen has submitted this change and it was merged.
Change subject: userportal, webadmin: remove FF17, add FF31 to supported
browsers
..
userportal, webadmin: remove FF17, add FF31 to supported browsers
Change-Id: I2fbc2d
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: xsrf token changes
..
Patch Set 4:
Thanks, Alon.
@Vojtech - "+2"?
--
To view, visit http://gerrit.ovirt.org/31089
To unsubscribe, visit ht
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: remove FF17, add FF31 to supported
browsers
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33280/1/frontend/webadmin/modules/webad
Einav Cohen has posted comments on this change.
Change subject: frontend: Upgrade GWT to version 2.6.1
..
Patch Set 5:
guys, let's wait for Monday to merge please :) thanks.
--
To view, visit http://gerrit.ovirt.org/32135
To
Einav Cohen has posted comments on this change.
Change subject: userportal,webadmin: messages locale unit test
..
Patch Set 1:
> Also wrong indexes and missing default messages.
@Alexander: I think that the unit-test should f
1 - 100 of 1160 matches
Mail list logo
