Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: messages locale unit test ......................................................................
Patch Set 1: > Also wrong indexes and missing default messages. @Alexander: I think that the unit-test should fail only in case of an error that would have failed the build (without unit-tests) when compiling in all-lang. when compiling with all-lang: does a missing default message fail the build? if not - maybe worth removing this check or cause it to throw a warning instead of failing the build. thanks. -- To view, visit http://gerrit.ovirt.org/32995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icda389f2ca08e9d3b7515bb4a0dc1213bc91aeef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
