Einav Cohen has posted comments on this change. Change subject: webadmin: Fix UI plugin REST API / Engine session refresh issue ......................................................................
Patch Set 5: > ... so the scenario you wrote above is not possible, I think. consider the following scenario: UserSessionTimeOutInterval=2 - 12:00:00: engine expires expired sessions. - 12:00:01: user login to web-admin, web-admin http session (w1), rest-api http session (r1) are created, all pointing to a newly-created engine session (e1). there is no user interaction, the ui-plugins are not performing any rest-api requests. - 12:02:00: engine expires expired sessions. e1 is 1m59sec old, so it is not expired. w1 and r1 are still alive as well (their TTL is 2 minutes, just like UserSessionTimeOutInterval). - 12:02:01: r1 is expired. e1 is still alive (and will be until 12:04:00). - 12:02:02: user performs an action / ui-plugin makes a rest-api request -> a rest-api request is performed (either immediately, or sometime in the upcoming minute). r1 is expired, therefore rest-api request cannot be fulfilled -> browser displays a credentials-request-for-rest-api pop-up. -- To view, visit http://gerrit.ovirt.org/36622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ffd3198239040f67313238a837af98db16e79ea Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
