Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: convert all grids (Cells) to PatternFly tooltips ......................................................................
Patch Set 25: (1 comment) https://gerrit.ovirt.org/#/c/37935/25/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java: Line 47: } Line 48: Line 49: private String getTooltipText(VMStatus status) { Line 50: Line 51: // TODO: (Einav?) is it ok to show all these tooltips in userportal? since this used to be the output of statusTranslator which did pretty much a 1:1 status mapping (as you found out), the answer is probably yes. I think that you can remove this comment (you can do it later on obviously - this shouldn't block merging this patch). thanks. Line 52: // TODO tt used to be statusTranslator.translate(value.getStatus().name()); Line 53: Line 54: switch (status) { Line 55: case Up: -- To view, visit https://gerrit.ovirt.org/37935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54820570f3dd9cd8306ba63a263c480b33eeb65d Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
