Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: convert remaining widgets to PatternFly tooltips ......................................................................
Patch Set 14: re-tested with updated patches: > 1. There are no tool-tips on cropped grid-column text headers > [https://raw.githubusercontent.com/eco-public/clipboard/master/out-23.ogv] > or on icon column headers (I don't have a screen-cast for that). > For grid-column text headers: when cropped, it would be nice to > have them with the "..." suffix, just like text-cells in the grids' > body (we never had the ellipsis feature for column text *headers*, > I think). tool-tips on icon column headers - fixed. ellipsis + tool-tips on cropped text column headers - not fixed, however I assume will be treated separately in the context of bug 1199725? > > 2. Grid column-sorting behavior is completely off: When clicking > the column header, nothing happens. Re-size the column - the > sorting-triangle icon suddenly appears (on-mouse-leave). Another > click on the column header - nothing happens. Re-size the column > again - sorting-triangle icon suddenly flips (allegedly indicating > that sorting was reversed). Throughout this entire scenario - *no > sorting is actually being performed* > [https://raw.githubusercontent.com/eco-public/clipboard/master/out-24.ogv]. fixed - works perfectly. > > 3. When hovering over the grid column headers from left to right - > mouse cursor seems OK. However, when hovering over the grid column > headers from right to left - mouse cursor gets "stuck" on the > column-resize icon (pointing out that there are no mouse-clicks > involved in this scenario - only hovering) > [https://raw.githubusercontent.com/eco-public/clipboard/master/out-25.ogv]. fixed. > > 4. [Most likely not related to your patch, but mentioning anyway > just in case it somehow is] Widths of grid-columns in the Disks > main-tab are evenly distributed, which looks strange > [http://i.imgur.com/yVvSqb5.png]. fixed. > > 5. [May be related to 4 / may not be related to your patches] > Re-sizing of the Disks' grid-columns is behaving strange (re-sizing > one column unexpectedly affects other columns as well) > [https://raw.githubusercontent.com/eco-public/clipboard/master/out-26.ogv]. fixed. > > 6. Tool-tips for the "Attached to" column in the Disks grid are > "regular" tool-tips (i.e. tool-tips that show the full cell-text > when it is cropped), which is OK for Disks that are attached to > only one VM/Template. But in case a Disk is attached to more than > one VM and the grid-cell shows e.g. "2 VMs", need a tool-tip that > (a) will contain the actual names of the VMs (e.g. "VM1, VM2") and > (b) will be displayed upon hovering always (and not only when text > is cropped) [same image as 4]. fixed (works perfectly for "plain" cropped text as well as text that needs to be detailed). > > Thanks. -- To view, visit https://gerrit.ovirt.org/38360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic247147c091f4fa6e6c09689c85b6901c74f11f3 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
