Einav Cohen has posted comments on this change. Change subject: WIP: new Tooltip infrastructure ......................................................................
Patch Set 3: see https://raw.githubusercontent.com/eco-public/clipboard/master/out-6.ogv: the tool-tips themselves look great, their behavior though is somewhat sluggish: - it takes them a little bit of time to appear after hovering on the icon. - a tooltip may appear when the user has already hovered-out of the relevant icon. - two tool-tips may appear at the same time. - tool-tips may take a significant amount of time to disappear. and this is only what I discovered in very few minutes of testing this patch - I'm afraid that the current implementation is less-than-ideal from a UX perspective, and may be prone to unexpected behaviors and users' complaints. @Greg: - With your patch applied: are there any PatternFly tool-tips in the GUI that are not in a grid? - Assuming tool-tips behave seamlessly in the GUI in locations other than the grids: I am wondering whether we should, for now, "fallback" to native browser tool-tips in the grids, and migrate to PatternFly tool-tips only in places that are not re-rendered upon refresh [e.g. dialogs, action-buttons (?), etc.] Thoughts/Comments are welcome. Thanks. -- To view, visit http://gerrit.ovirt.org/36530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f82efada76f8b4654f034c428246f27ebe55889 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
