Einav Cohen has posted comments on this change.

Change subject: webadmin : CheckBoxGroup, DaysOfMonthSelector and DateTimeBox 
Widgets
......................................................................


Patch Set 4:

(1 comment)

@Greg, do we know if PatternFly has any date-time selection solution planned 
(or maybe already in place - couldn't find one though)?

http://gerrit.ovirt.org/#/c/37302/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/DaysOfMonthSelector.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/DaysOfMonthSelector.java:

Line 72:             daysOfMonth.getCellFormatter().getElement(row, 
column).addClassName("normalFlexTableCell");//$NON-NLS-1$
Line 73:             clickedMap.put(i, false);
Line 74:             column++;
Line 75:         }
Line 76:         Label widget = new Label("Last Day");//$NON-NLS-1$
localize "Last Day"?
Line 77:         daysOfMonth.setWidget(row, column, widget);
Line 78:         daysOfMonth.getFlexCellFormatter().setColSpan(row, column, 4);
Line 79:         clickedMap.put(32, false);
Line 80:         wrapperPanel.add(daysOfMonth);


-- 
To view, visit http://gerrit.ovirt.org/37302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38daa0d2c151eb0e34603488496a8a1ea4719c87
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to