Arik Hadas has posted comments on this change.
Change subject: core: move cached info about last event to vm-manager
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/42469/6/backend/manager/modules/vdsbroker/src/main/j
Arik Hadas has posted comments on this change.
Change subject: core: prevent npe when vm disappears from vdsm
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/42468/5/backend/manager/modules/vdsbroker/src/main/java/org
Arik Hadas has posted comments on this change.
Change subject: core: move cached info about last event to vm-manager
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/42469/6/backend/manager/modules/vdsbroker/src/main/j
Arik Hadas has posted comments on this change.
Change subject: core: prevent npe when vm disappears from vdsm
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/42468/5/backend/manager/modules/vdsbroker/src/main/java/org
Arik Hadas has posted comments on this change.
Change subject: core: remove unused method
..
Patch Set 2: Continuous-Integration+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/42467
To unsubscribe, visit https://gerri
Arik Hadas has posted comments on this change.
Change subject: core: remove unused method
..
Patch Set 3: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/42467
To unsubscribe, visit https://gerrit.ovirt.org
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove unused method
..
core: remove unused method
VmsMonitoring#resetStatusUpdateTime was unused, thus removed.
Change-Id: I8ca6110451758c3ce5209c8
Arik Hadas has submitted this change and it was merged.
Change subject: core: add ctor to VmInternalData (2)
..
core: add ctor to VmInternalData (2)
Add constructor that gets VmDynamic and VmStatistics
Change-Id: I8233a7de380c
Arik Hadas has posted comments on this change.
Change subject: core: add ctor to VmInternalData (2)
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/42463
To unsubscribe, visit https://gerrit
Arik Hadas has posted comments on this change.
Change subject: core: add ctor to VmInternalData (2)
..
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/42463
To unsubscribe, visit https://gerrit
Arik Hadas has posted comments on this change.
Change subject: core: add ctor to VmInternalData (2)
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42463
To unsubscribe, visit https://gerrit.ovirt.org/set
Arik Hadas has posted comments on this change.
Change subject: core: cleanup in EventVmStatsRefresher (2)
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/42466/3/backend/manager/modules/vdsbroker/src/main/java/org/ov
Arik Hadas has posted comments on this change.
Change subject: core: move vdsm timestamp to VmInternalData
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42464/3/backend/manager/modules/vdsbroker/src/main/java/org/ov
Arik Hadas has submitted this change and it was merged.
Change subject: core: add another ctor to VmInternalData
..
core: add another ctor to VmInternalData
Add constructor that gets only VmDynamic
Change-Id: I149fb3557fcc4926
Arik Hadas has posted comments on this change.
Change subject: core: add another ctor to VmInternalData
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42462
To unsubscribe, visit https://gerrit.ovirt.org
Arik Hadas has uploaded a new change for review.
Change subject: core: move cached info about last event to vm-manager
..
core: move cached info about last event to vm-manager
The caching of the timestamp of the last event we go
Arik Hadas has uploaded a new change for review.
Change subject: core: remove unused method
..
core: remove unused method
VmsMonitoring#resetStatusUpdateTime was unused, thus removed.
Change-Id: I8ca6110451758c3ce5209c85b07aace
Arik Hadas has uploaded a new change for review.
Change subject: core: move vdsm timestamp to VmInternalData
..
core: move vdsm timestamp to VmInternalData
Move the timestamp we get from VDSM on List/VmStats/AllVmStats to be in
Arik Hadas has uploaded a new change for review.
Change subject: core: prevent npe when vm disappears from vdsm
..
core: prevent npe when vm disappears from vdsm
VmInternalData is set to null for a VM that disappeared from the h
Arik Hadas has uploaded a new change for review.
Change subject: core: add ctor to VmInternalData (2)
..
core: add ctor to VmInternalData (2)
Add constructor that gets VmDynamic and VmStatistics
Change-Id: I8233a7de380c3831eda2
Arik Hadas has uploaded a new change for review.
Change subject: core: prevent a race on getAllStats with events
..
core: prevent a race on getAllStats with events
046b36e7 introduced a timestamp for vm-dynamic updates. This pat
Arik Hadas has uploaded a new change for review.
Change subject: core: cleanup in EventVmStatsRefresher
..
core: cleanup in EventVmStatsRefresher
1. The VM that is being created in createVmInternalData is based on the
VM from th
Arik Hadas has uploaded a new change for review.
Change subject: core: cleanup in EventVmStatsRefresher (2)
..
core: cleanup in EventVmStatsRefresher (2)
Move code that parses maps we get from VDSM to VdsBrokerObjectsBuilder
Ch
Arik Hadas has uploaded a new change for review.
Change subject: core: add another ctor to VmInternalData
..
core: add another ctor to VmInternalData
Add constructor that gets only VmDynamic
Change-Id: I149fb3557fcc4926e1ac7094
Arik Hadas has posted comments on this change.
Change subject: events: removing vm.getStats from event processing
..
Patch Set 19: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40205
To unsubscribe, visit https://ge
Arik Hadas has submitted this change and it was merged.
Change subject: events: VM Status based on an event
..
events: VM Status based on an event
Change-Id: If5b35877ccd63372759ad6989280e9417c259b21
Signed-off-by: pkliczewski
Arik Hadas has submitted this change and it was merged.
Change subject: events: vm stats refresher refactoring
..
events: vm stats refresher refactoring
Change-Id: I40139f9c90bd9ceeb297adf9f8bd3ab7f9113930
Signed-off-by: pklicz
Arik Hadas has posted comments on this change.
Change subject: events: vm stats refresher refactoring
..
Patch Set 26: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37487
To unsubscribe, visit https://gerrit.ovirt.o
Arik Hadas has posted comments on this change.
Change subject: events: removing vm.getStats from event processing
..
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40205
To unsubscribe, visit https://ge
Arik Hadas has posted comments on this change.
Change subject: events: removing vm.getStats from event processing
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/40205/18/backend/manager/modules/vdsbroker/src/test/ja
Arik Hadas has posted comments on this change.
Change subject: core: CommandBase - adding noAsyncOperations()
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41694
To unsubscribe, visit https://gerrit.
Arik Hadas has posted comments on this change.
Change subject: core: CommandBase - adding noAsyncOperations()
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/41694/8/backend/manager/modules/bll/src/main/java/org/ovirt
Arik Hadas has posted comments on this change.
Change subject: core: add timestamp for vm-dynamic updates
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41520
To unsubscribe, visit https://gerrit.ovir
Arik Hadas has posted comments on this change.
Change subject: core: CommandBase - avoid releasing lock if there is a callback
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41692
To unsubscribe, visi
Arik Hadas has posted comments on this change.
Change subject: core: CommandBase - adding noAsyncOperations()
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/41694/8/backend/manager/modules/bll/src/main/java/org/ovirt
Arik Hadas has posted comments on this change.
Change subject: core: VM configuration should not be validated in Export Domain
..
Patch Set 1: Code-Review+1
(1 comment)
this is another evidence that ImportVmFromConfiguration s
Arik Hadas has posted comments on this change.
Change subject: core: CommandBase - end job after execution only if there is no
callback
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41693
To unsubsc
Arik Hadas has posted comments on this change.
Change subject: events: removing vm.getStats from event processing
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/40205/17/backend/manager/modules/vdsbroker/src/main/ja
Arik Hadas has posted comments on this change.
Change subject: events: removing vm.getStats from event processing
..
Patch Set 17:
(6 comments)
https://gerrit.ovirt.org/#/c/40205/17/backend/manager/modules/common/src/main/java
Arik Hadas has posted comments on this change.
Change subject: events: removing vm.getStats from event processing
..
Patch Set 15:
(5 comments)
https://gerrit.ovirt.org/#/c/40205/15/backend/manager/modules/vdsbroker/src/main/j
Arik Hadas has posted comments on this change.
Change subject: events: vm stats refresher refactoring
..
Patch Set 23: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37487
To unsubscribe, visit https://gerrit.ovirt.o
Arik Hadas has posted comments on this change.
Change subject: events: VM Status based on an event
..
Patch Set 25: Code-Review+1
(1 comment)
minor comment inside
https://gerrit.ovirt.org/#/c/37488/25/backend/manager/modules/
Arik Hadas has posted comments on this change.
Change subject: events: removing vm.getStats from event processing
..
Patch Set 15:
(5 comments)
partial review
https://gerrit.ovirt.org/#/c/40205/15/backend/manager/modules/vdsb
Arik Hadas has posted comments on this change.
Change subject: events: VM Status based on an event
..
Patch Set 24:
(2 comments)
https://gerrit.ovirt.org/#/c/37488/24/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/e
Arik Hadas has posted comments on this change.
Change subject: core: calculate console_client_resources_url if not provided
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42273
To unsubscribe, visit h
Arik Hadas has posted comments on this change.
Change subject: events: vm stats refresher refactoring
..
Patch Set 21: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37487
To unsubscribe, visit https://gerrit.ovirt.o
Arik Hadas has submitted this change and it was merged.
Change subject: core: calculate the engine base url if not provided
..
core: calculate the engine base url if not provided
If the engine base URL is not provided, calculat
Arik Hadas has posted comments on this change.
Change subject: core: calculate the engine base url if not provided
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42262
To unsubscribe, visit https://ge
Arik Hadas has posted comments on this change.
Change subject: engine: Removal of VM pool with VMs
..
Patch Set 6:
(11 comments)
partial review.
comments inside and in addition, you don't need to modify the localized
app-erro
Arik Hadas has submitted this change and it was merged.
Change subject: core: Correct VmPool.hashCode() and equals()
..
core: Correct VmPool.hashCode() and equals()
Using the same set of fields for both hashCode() and equals()
Arik Hadas has posted comments on this change.
Change subject: core: Correct VmPool.hashCode() and equals()
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41903
To unsubscribe, visit https://gerrit.ov
Arik Hadas has posted comments on this change.
Change subject: webadmin: select virtio drivers iso on import vm
..
Patch Set 2:
@Tomas, I did not manage to do it with FlowPanel so I used HorizontalPanel (my
reference was Abstr
Arik Hadas has posted comments on this change.
Change subject: webadmin: select virtio drivers iso on import vm
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42259
To unsubscribe, visit https://gerrit.o
Arik Hadas has posted comments on this change.
Change subject: core: calculate console_client_resources_url if not provided
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42273
To unsubscribe, visit h
Arik Hadas has posted comments on this change.
Change subject: core: calculate the engine base url if not provided
..
Patch Set 1:
@Tomas, this patch looks good but I'm not sure who maintains EngineLocalConfig
and if I can giv
Arik Hadas has posted comments on this change.
Change subject: core: calculate the engine base url if not provided
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42262
To unsubscribe, visit https://ge
Arik Hadas has posted comments on this change.
Change subject: core: fix findbugs
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42257
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Mess
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: virtio-tools
..
webadmin: virtio-tools
Change-Id: I7fd184bb4847dd07e1ac6b831c6857eeb8a16fc7
Signed-off-by: Arik Hadas
---
M
frontend/webadmin/modules/g
Arik Hadas has uploaded a new change for review.
Change subject: core: fix findbugs
..
core: fix findbugs
Fix RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
Change-Id: Ie614377ee4715cc4cd9a5bd6ec7eba4a20aa8a0e
Signed-off-by: Ari
Arik Hadas has uploaded a new change for review.
Change subject: core: virtio-drivers
..
core: virtio-drivers
Change-Id: I4f77c0980d903061f20e03851eec5406ee181540
Signed-off-by: Arik Hadas
---
M
backend/manager/modules/common/
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: os selection for import from VMware
..
webadmin: os selection for import from VMware
We cannot know what is the operating system that is installe
Arik Hadas has posted comments on this change.
Change subject: webadmin: os selection for import from VMware
..
Patch Set 54: Code-Review+2 Verified+1
the current findbugs error is not related to this change
--
To view, visit
Arik Hadas has posted comments on this change.
Change subject: core: added support for version check for remote-viewer
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41879
To unsubscribe, visit https:
Arik Hadas has posted comments on this change.
Change subject: Revert "core: Fix cascade delete with Job/Step"
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42229
To unsubscribe, visit https://gerrit
Arik Hadas has posted comments on this change.
Change subject: core: send maxMemory to vdsm on run vm
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40553
To unsubscribe, visit https://gerrit.ovirt.or
Arik Hadas has posted comments on this change.
Change subject: core: Memory Hotplug
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/35081
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
Arik Hadas has posted comments on this change.
Change subject: core: added support for version check for remote-viewer
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41879
To unsubscribe, visit https:
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: support import from VMware
..
webadmin: support import from VMware
Add an option to use VMware as a source in the import VM dialog.
Change-Id: I
Arik Hadas has submitted this change and it was merged.
Change subject: backend: Parse 'hostdevPassthrough' host capability
..
backend: Parse 'hostdevPassthrough' host capability
Added new host field to track whether the device
Arik Hadas has posted comments on this change.
Change subject: backend: Parse 'hostdevPassthrough' host capability
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40714
To unsubscribe, visit https://g
Arik Hadas has posted comments on this change.
Change subject: core: add support for power8e cpu
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42131
To unsubscribe, visit https://gerrit.ovirt.org/set
Arik Hadas has posted comments on this change.
Change subject: webadmin: support import from VMware
..
Patch Set 124: Verified+1
--
To view, visit https://gerrit.ovirt.org/33053
To unsubscribe, visit https://gerrit.ovirt.org/s
Arik Hadas has posted comments on this change.
Change subject: core: Memory Hotplug
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/35081/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetAmo
Arik Hadas has submitted this change and it was merged.
Change subject: core: introduce DiskContentType
..
core: introduce DiskContentType
Generalize the ovf-store into a content-type of disk. Ovf-store is just
one example for
Arik Hadas has abandoned this change.
Change subject: webadmin: fix findbug
..
Abandoned
another fix was merged before
--
To view, visit https://gerrit.ovirt.org/42190
To unsubscribe, visit https://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: webadmin: fix findbug
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42190
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-M
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: fix findbug
..
webadmin: fix findbug
Fix BC_VACUOUS_INSTANCEOF error.
Change-Id: I05d675633c1760398e77b8480f00d0a33d2e71d9
Signed-off-by: Arik Hadas
--
Arik Hadas has posted comments on this change.
Change subject: core: added support for version check for remote-viewer
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/41879/6/packaging/dbscripts/upgrade/pre_upgrade/00
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: load vms from export domain on-demand
..
webadmin: load vms from export domain on-demand
Do not load VMs from the export domain until the user cl
Arik Hadas has posted comments on this change.
Change subject: webadmin: load vms from export domain on-demand
..
Patch Set 11: Code-Review+2 Verified+1
the findbugs error is unrelated to this patch
--
To view, visit https://
Arik Hadas has posted comments on this change.
Change subject: backend: Added missing mapping for Australia/Darwin
..
Patch Set 1:
(Omer, I can't think of any solution for forward-compatibility for this case:
1. prevent setting
Arik Hadas has posted comments on this change.
Change subject: backend: Added missing mapping for Australia/Darwin
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42149
To unsubscribe, visit https://ge
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix permissions check on import vm
..
core: fix permissions check on import vm
Changing import VM commands to extend VmCommand, caused them not to us
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: progress monitor for import vm
..
webadmin: progress monitor for import vm
Change-Id: I080950e6484c9612e26bd26dfc5367b45b7e854c
Signed-off-by: Ar
Arik Hadas has submitted this change and it was merged.
Change subject: core: progress monitor for import vm
..
core: progress monitor for import vm
Report the progress of import VM from external provider to the UI
Change-Id:
Arik Hadas has posted comments on this change.
Change subject: webadmin: add info panel for import dialog
..
Patch Set 18: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42016
To unsubscribe, visit https://gerrit.ovi
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: add info panel for import dialog
..
webadmin: add info panel for import dialog
Add a panel that contains information about the export domain we a
Arik Hadas has posted comments on this change.
Change subject: webadmin: add info panel for import dialog
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/42016
To unsubscribe, visit https://gerrit.ovirt.
Arik Hadas has posted comments on this change.
Change subject: core: Memory Hotplug
..
Patch Set 5:
(9 comments)
https://gerrit.ovirt.org/#/c/35081/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetAm
Arik Hadas has posted comments on this change.
Change subject: core: send maxMemory to vdsm on run vm
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40553
To unsubscribe, visit https://gerrit.ovirt.or
Arik Hadas has posted comments on this change.
Change subject: core: always send numa node for vm
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40481
To unsubscribe, visit https://gerrit.ovirt.org/se
Arik Hadas has posted comments on this change.
Change subject: core: add configuration for hot plug memory
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41138
To unsubscribe, visit https://gerrit.ovi
Arik Hadas has submitted this change and it was merged.
Change subject: core: fixed visibility
..
core: fixed visibility
Bug-Url: https://bugzilla.redhat.com/1200952
Change-Id: Ia31d63a9281b337ad9f6e2c7fd09ce375b76992c
Signed-o
Arik Hadas has submitted this change and it was merged.
Change subject: core: altered IsoDomainListSyncronizer to refresh and return
really *all* files if asked for it
..
core: altered IsoDomainListSyncronizer to refresh and re
Arik Hadas has posted comments on this change.
Change subject: core: altered IsoDomainListSyncronizer to refresh and return
really *all* files if asked for it
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovi
Arik Hadas has posted comments on this change.
Change subject: webadmin: load vms from export domain on-demand
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/42096
To unsubscribe, visit https://gerrit.ov
Arik Hadas has posted comments on this change.
Change subject: core: fix permissions check on import vm
..
Patch Set 41: Verified+1
--
To view, visit https://gerrit.ovirt.org/40572
To unsubscribe, visit https://gerrit.ovirt.or
Arik Hadas has posted comments on this change.
Change subject: core: progress monitor for import vm
..
Patch Set 45: Code-Review+2 Verified+1
based on omer's ack
--
To view, visit https://gerrit.ovirt.org/39879
To unsubscribe
Arik Hadas has posted comments on this change.
Change subject: webadmin: progress monitor for import vm
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42124
To unsubscribe, visit https://gerrit.ovirt.org
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: progress monitor for import vm
..
webadmin: progress monitor for import vm
Change-Id: I080950e6484c9612e26bd26dfc5367b45b7e854c
Signed-off-by: Arik Hadas
1 - 100 of 3507 matches
Mail list logo
