Arik Hadas has posted comments on this change. Change subject: core: prevent npe when vm disappears from vdsm ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/42468/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 170: return Injector.get(SchedulerUtilQuartzImpl.class); Line 171: } Line 172: Line 173: public boolean shouldUpdateVmStatus(VmInternalData vmInternalData) { Line 174: if (vmInternalData == null) { > Hmm, so what is the value of having null for VmInternalData. Should we make I'm not sure I understand the question. The VmsMonitoring should be able to handle the case where it is null, we just need to pass it to VmsMonitoring and not crash beforehand Line 175: // VM disappeared from VDSM, we need to have monitoring cycle Line 176: return true; Line 177: } Line 178: Guid id = vmInternalData.getVmDynamic().getId(); -- To view, visit https://gerrit.ovirt.org/42468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I048866e03ae8b25d5b67e6b1be78046166c92217 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
