Arik Hadas has posted comments on this change. Change subject: core: VM configuration should not be validated in Export Domain ......................................................................
Patch Set 1: Code-Review+1 (1 comment) this is another evidence that ImportVmFromConfiguration should not extend ImportVm.. anyway, minor comment inside and besides that it looks good https://gerrit.ovirt.org/#/c/42395/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 232: if (validator.isDomainExistAndActive().isValid() && getSourceDomain().getStorageDomainType() != StorageDomainType.ImportExport) { Line 233: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL); Line 234: } Line 235: if (!validateAndSetVmFromExportDomain()) Line 236: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_FOUND_ON_EXPORT_DOMAIN); missing { and } Line 237: } Line 238: Line 239: if (!validateImages(domainsMap)) { Line 240: return false; -- To view, visit https://gerrit.ovirt.org/42395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffde1e02cfa9c1c104f1f7057fb4218c44da599b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
