Arik Hadas has uploaded a new change for review.

Change subject: core: prevent a race on getAllStats with events
......................................................................

core: prevent a race on getAllStats with events

046b36e7 introduced a timestamp for vm-dynamic updates. This patch fixes
the timestamp that is saved on getAllVmStats with events similarly.

Change-Id: I90ee66124564756f82b93f762c631c518444f678
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/70/42470/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
index 0bb48df..b0e774b 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
@@ -123,11 +123,12 @@
         if (this.manager.isMonitoringNeeded() && getRefreshStatistics()) {
             VmsListFetcher fetcher = new VmsStatisticsFetcher(this.manager);
 
+            long fetchTime = System.nanoTime();
             fetcher.fetch();
 
             new VmsMonitoring(this.manager,
                     fetcher.getChangedVms(),
-                    fetcher.getVmsWithChangedDevices(), this.auditLogDirector, 
System.nanoTime()).perform();
+                    fetcher.getVmsWithChangedDevices(), this.auditLogDirector, 
fetchTime).perform();
         }
     }
 }


-- 
To view, visit https://gerrit.ovirt.org/42470
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I90ee66124564756f82b93f762c631c518444f678
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to