Arik Hadas has posted comments on this change. Change subject: core: calculate the engine base url if not provided ......................................................................
Patch Set 1: @Tomas, this patch looks good but I'm not sure who maintains EngineLocalConfig and if I can give +2 on that. I think it is infra's code, so I added Moti. In the worst case we'll try to merge it on Sunday, if there will be minor comments, we'll address them. -- To view, visit https://gerrit.ovirt.org/42262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6eba8a1becce0d08596db20886361258289c09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
