Arik Hadas has posted comments on this change. Change subject: events: VM Status based on an event ......................................................................
Patch Set 25: Code-Review+1 (1 comment) minor comment inside https://gerrit.ovirt.org/#/c/37488/25/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java: Line 13: public class RefresherFactory { Line 14: Line 15: public static VMStatsRefresher create(final VdsManager manager, final AuditLogDirector auditLogDirector, final SchedulerUtil scheduler) { Line 16: Version version = manager.getCompatibilityVersion(); Line 17: if (FeatureSupported.jsonProtocol(version) && VdsProtocol.STOMP.equals(manager.getCopyVds().getProtocol()) seems like you forgot to change the enum comparison since you wrote Done on previous patch-set Line 18: && FeatureSupported.vmStatsEvents(version)) { Line 19: return new EventVMStatsRefresher(manager, auditLogDirector, scheduler); Line 20: } Line 21: return new PollVMStatsRefresher(manager, auditLogDirector, scheduler); -- To view, visit https://gerrit.ovirt.org/37488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5b35877ccd63372759ad6989280e9417c259b21 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
