[Engine-patches] Change in ovirt-dwh[master]: History: Fixed ad_domain datatype

2014-02-15 Thread sradco
Shirly Radco has posted comments on this change. Change subject: History: Fixed ad_domain datatype .. Patch Set 1: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24499 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-dwh[master]: History: Fixed ad_domain datatype

2014-02-15 Thread sradco
Shirly Radco has uploaded a new change for review. Change subject: History: Fixed ad_domain datatype .. History: Fixed ad_domain datatype Made a mistake in configuring the datatype in views to preserve the views legacy. This fix

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Permissions of group are not inherited when adding a user

2014-02-15 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: Permissions of group are not inherited when adding a user .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24494 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: tools: extract MAIL_RETRIES to configuration

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: extract MAIL_RETRIES to configuration .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkst

[Engine-patches] Change in ovirt-engine[master]: tools: Support snmp trap as a notification method.

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. .. Patch Set 30: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_

[Engine-patches] Change in ovirt-engine[master]: tools: more changes in NotificationProperties

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: more changes in NotificationProperties .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: tools: Notification properties changes.

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Notification properties changes. .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: tools: remove sql link between notification_subscribers and ...

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: remove sql link between notification_subscribers and users. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master

[Engine-patches] Change in ovirt-engine[master]: tools: remove SmtpTest.

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: remove SmtpTest. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/18294/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: tools: implement and use transport.idle().

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: implement and use transport.idle(). .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerri

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 9: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compil

[Engine-patches] Change in ovirt-engine[master]: tools: Rename EventNotificationMethods to EventNotificationM...

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Rename EventNotificationMethods to EventNotificationMethod. .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_maste

[Engine-patches] Change in ovirt-engine[master]: utils: add getProperty with an optionalSuffix String.

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add getProperty with an optionalSuffix String. .. Patch Set 9: -Verified Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_com

[Engine-patches] Change in ovirt-engine[master]: tools: Remove auxiliary email address from EventSender inter...

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Remove auxiliary email address from EventSender interface .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_c

[Engine-patches] Change in ovirt-engine[master]: tools: Refactor model and DB mapping of eventNotificationMet...

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Refactor model and DB mapping of eventNotificationMethods. .. Patch Set 32: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master

[Engine-patches] Change in ovirt-engine[master]: tools: fix NotificationPropertiesTest.

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: fix NotificationPropertiesTest. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/18285/

[Engine-patches] Change in ovirt-engine[master]: tools: remove smtp host validation on notifier startup

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: remove smtp host validation on notifier startup .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checksty

[Engine-patches] Change in ovirt-engine[master]: tools: Required changes in events data mapping.

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Required changes in events data mapping. .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle

[Engine-patches] Change in ovirt-engine[master]: 5. [WIP] core: Introducing configuration loader

2014-02-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: 5. [WIP] core: Introducing configuration loader .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/24365/4/backend/manager/modules/extension-manager/src/m

[Engine-patches] Change in ovirt-engine[master]: tools: implement and use transport.idle().

2014-02-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: implement and use transport.idle(). .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24472/2/backend/manager/tools/src/main/java/org/ovirt/engine/c

[Engine-patches] Change in ovirt-engine[master]: tools: implement and use transport.idle().

2014-02-15 Thread mtayer
mooli tayer has posted comments on this change. Change subject: tools: implement and use transport.idle(). .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24472/2/backend/manager/tools/src/main/java/org/ovirt/engine/co

[Engine-patches] Change in ovirt-engine[master]: 5. [WIP] core: Introducing configuration loader

2014-02-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: 5. [WIP] core: Introducing configuration loader .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/24365/4/backend/manager/modules/extension-manager/src/mai

[Engine-patches] Change in ovirt-engine[master]: 5. [WIP] core: Introducing configuration loader

2014-02-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: 5. [WIP] core: Introducing configuration loader .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/24365/4/backend/manager/modules/extension-manager/src/m

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/24018/8/backend/manager/tools/src/main/java/org/ovi

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/24018/8/backend/manager/tools/src/main/java/org/ovi

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/24018/8/backend/manager/tools/src/main/java/org/ovi

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-15 Thread mtayer
mooli tayer has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/24018/8/backend/manager/tools/src/main/java/org/ovir

[Engine-patches] Change in gerrit-admin[master]: New way of running

2014-02-15 Thread dcaroest
David Caro has abandoned this change. Change subject: New way of running .. Abandoned Changes added to patch http://gerrit.ovirt.org/#/c/19600/ -- To view, visit http://gerrit.ovirt.org/24496 To unsubscribe, visit http://gerr

[Engine-patches] [oVirt Jenkins] ovirt_engine_master_find_bugs - Build # 6821 - Still Unstable!

2014-02-15 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6821/ Build Number: 6821 Build Status: Still Unstable Triggered By: Started by an SCM change - Changes Since Last Success: --

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Permissions of group are not inherited when adding a user

2014-02-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Permissions of group are not inherited when adding a user .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24494 To uns

[Engine-patches] Change in ovirt-engine[master]: core: Permissions of group are not inherited when adding a user

2014-02-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Permissions of group are not inherited when adding a user .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24493 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Permissions of group are not inherited when adding a user

2014-02-15 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Permissions of group are not inherited when adding a user .. core: Permissions of group are not inherited when adding a user When adding a user,

[Engine-patches] Change in ovirt-engine[master]: core: Permissions of group are not inherited when adding a user

2014-02-15 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Permissions of group are not inherited when adding a user .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24493 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: Modify GetAllConnectableStorageConnections procedure...

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Modify GetAllConnectableStorageConnections procedure and DAO .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engi

[Engine-patches] Change in ovirt-engine[master]: engine: Only iSCSI storage connections are viable for iSCSI ...

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_co

[Engine-patches] Change in ovirt-engine[master]: engine: Only iSCSI storage connections are viable for iSCSI ...

2014-02-15 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond .. Patch Set 4: I changed existing stored procedure due to Liron's and Allon's comments here ht

[Engine-patches] Change in ovirt-engine[master]: engine: Modify GetAllConnectableStorageConnections procedure...

2014-02-15 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Modify GetAllConnectableStorageConnections procedure and DAO .. Patch Set 1: I took Allon's and Liron's advise from here http://gerrit.ovirt.org/#/c/237

[Engine-patches] Change in ovirt-engine[master]: engine: Modify GetAllConnectableStorageConnections procedure...

2014-02-15 Thread sgotliv
Sergey Gotliv has uploaded a new change for review. Change subject: engine: Modify GetAllConnectableStorageConnections procedure and DAO .. engine: Modify GetAllConnectableStorageConnections procedure and DAO Allows to retrieve

[Engine-patches] Change in ovirt-engine[master]: tools: Adds bash completion for engine-manage-domains

2014-02-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: Adds bash completion for engine-manage-domains .. Patch Set 1: For the location, you are incorrect: # rpm -qf /usr/share/bash-completion/ yum-3.4.3-111.

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/24018/8/backend/manager/tools/src/main/java/org/ovi

[Engine-patches] Change in ovirt-engine[master]: tools: implement and use transport.idle().

2014-02-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: implement and use transport.idle(). .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/24472/2/backend/manager/tools/src/main/java/org/ovirt/engine/

[Engine-patches] Change in gerrit-admin[master]: New way of running

2014-02-15 Thread dcaroest
David Caro has uploaded a new change for review. Change subject: New way of running .. New way of running * Only one review per commit, done by the dispatcher * Hooks must output the result on stdout and the results will be ag

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Permissions of group are not inherited when adding a user

2014-02-15 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Permissions of group are not inherited when adding a user .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24494 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: Permissions of group are not inherited when adding a user

2014-02-15 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Permissions of group are not inherited when adding a user .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24493 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: tools: Adds bash completion for engine-manage-domains

2014-02-15 Thread mperina
Martin Peřina has posted comments on this change. Change subject: tools: Adds bash completion for engine-manage-domains .. Patch Set 1: Alon, in /usr/share/bash-completion/completions/ there are only completions included in ba

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-15 Thread mtayer
mooli tayer has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 8: (3 comments) http://gerrit.ovirt.org/#/c/24018/8/backend/manager/tools/src/main/java/org/ovi

[Engine-patches] Change in ovirt-engine[master]: tools: Support snmp trap as a notification method.

2014-02-15 Thread mtayer
mooli tayer has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. .. Patch Set 29: (1 comment) http://gerrit.ovirt.org/#/c/22909/29/backend/manager/tools/src/main/java/org/ovirt

[Engine-patches] Change in ovirt-engine[master]: tools: implement and use transport.idle().

2014-02-15 Thread mtayer
mooli tayer has posted comments on this change. Change subject: tools: implement and use transport.idle(). .. Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/24472/2/backend/manager/tools/src/main/java/org/ovirt/engine/c

[Engine-patches] Change in ovirt-engine[master]: tools: implement and use transport.idle().

2014-02-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: implement and use transport.idle(). .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24472/2/backend/manager/tools/src/main/java/org/ovirt/engine/c

[Engine-patches] Change in ovirt-engine[master]: 6. [WIP] core: Introducing AuthenticationProfileRepository

2014-02-15 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: 6. [WIP] core: Introducing AuthenticationProfileRepository .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/24366/4/backend/manager/modules/aaa/src/main/j

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Permissions of group are not inherited when adding a user

2014-02-15 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Permissions of group are not inherited when adding a user .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_t