[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

[Alon Bar-Lev]

Alon Bar-Lev has posted comments on this change.

Change subject: tools: notifier - simple first match include/exclude.
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/24018/8/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
File 
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java:

Line 220: 
Line 221:     private void validateFilter() {
Line 222:         String filter = getProperty(NotificationProperties.FILTER, 
true);
Line 223:         if (filter != null)
Line 224:             FirstMatchSimpleFilter.parse(filter);
> as it does not make any sense to me... I dag some more...
As I read it more... I more cannot understand the argument of 'validate'...

The following loads and parse the configuration files.

    private NotificationProperties() {
        // Locate the defaults file and add it to the list:
        String defaultsPath = System.getenv("ENGINE_NOTIFIER_DEFAULTS");
        if (defaultsPath == null) {
            defaultsPath = DEFAULTS_PATH;
        }

        // Locate the overridden values file and add it to the list:
        String varsPath = System.getenv("ENGINE_NOTIFIER_VARS");
        if (varsPath == null) {
            varsPath = VARS_PATH;
        }

        loadConfig(defaultsPath, varsPath);
    }

There should be no problem to add the parsing of the filter just after the 
locaConfig() call.

As like we parse the configuration file, we parse values within.

There should be no problem to call the validate here as well... as the 
validation is done right after we load config.

As the LocalConfig has data, so that the NotificationProperties can.
Line 225:     }
Line 226: 
Line 227:     private void requireAll(String... mandatoryProperties) {
Line 228:         for (String property : mandatoryProperties) {


-- 
To view, visit http://gerrit.ovirt.org/24018
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches