Martin Peřina has posted comments on this change.

Change subject: tools: Adds bash completion for engine-manage-domains
......................................................................


Patch Set 1:

Alon, in /usr/share/bash-completion/completions/ there are only completions 
included in bash-completion package. Completions provided by other packages 
should be placed in /etc/bash_completion.d

About your previous comment: The engine-manage-domains was the first tool I 
made completions for, because of its large set of arguments. The 2nd tool on my 
mind is engine-config, where users could benefit from config keys completions 
(this can be done easily by parsing engine-config.properties)

-- 
To view, visit http://gerrit.ovirt.org/24483
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66d9733d9a4e380e40a457370f08483d832527c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to