mooli tayer has posted comments on this change. Change subject: tools: implement and use transport.idle(). ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/24472/2/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java: Line 48 Line 49 Line 50 Line 51 Line 52 > if you have mechanism to schedule call to run, why not use the same for cal I see. so you want the code scheduling calls to idle in notifier.java. I will revert changes and start over. Line 76: } Line 77: Line 78: private long getIdleInterval() { Line 79: return Integer.parseInt(NotificationProperties.IDLE_INTERVAL) * 1000; Line 80: } > why is that a function? Already fixed to getInteger Line 81: Line 82: private void processEvents() { Line 83: try { Line 84: try { http://gerrit.ovirt.org/#/c/24472/2/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in: Line 62: # the notification service cannot connect to the DB. can be empty. Line 63: # Deprecated, use FILTER with DATABASE_UNREACHABLE instead. Line 64: FAILED_QUERIES_NOTIFICATION_RECIPIENTS= Line 65: Line 66: # Wait at least IDLE_INTERVAL seconds before allowing a Transport to become idle. > we need two intervals... I see. So currently I will call every MAIL_SEND_INTERVAL to the Smtp.idle and every IDLE_INTERVAL to the empty Snmp.idele handler? Line 67: # An idle transport preforms background tasks like sending unsent queue. Line 68: IDLE_INTERVAL=30 Line 69: Line 70: #--------------# -- To view, visit http://gerrit.ovirt.org/24472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
