mooli tayer has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. ......................................................................
Patch Set 8: (3 comments) http://gerrit.ovirt.org/#/c/24018/8/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java: Line 30: "\\)" + Line 31: ")?" + Line 32: "\\s*" + Line 33: "" Line 34: ); > I really appreciate this! but our java standard states \t -> ' ' Done Line 35: private static final Logger log = Logger.getLogger(FirstMatchSimpleFilter.class); Line 36: private Map<String, Transport> transports = new HashMap<>(); Line 37: private List<FilterEntry> notify = new LinkedList<>(); Line 38: private Set<Recipient> recipients = new HashSet<>(); http://gerrit.ovirt.org/#/c/24018/8/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 219: } Line 220: Line 221: private void validateFilter() { Line 222: String filter = getProperty(NotificationProperties.FILTER, true); Line 223: if (filter != null) > I think there is some findbugs issue with not using {} not sure. Done Line 224: FirstMatchSimpleFilter.parse(filter); Line 225: } Line 226: Line 227: private void requireAll(String... mandatoryProperties) { Line 220: Line 221: private void validateFilter() { Line 222: String filter = getProperty(NotificationProperties.FILTER, true); Line 223: if (filter != null) Line 224: FirstMatchSimpleFilter.parse(filter); > please store result... This will require more changes. Currently NotificationProperties should not store any values except for the configurationFiles it is configured with. I would like having one class with only configuration names and methods to get them by types. A different immutable class will have all the properties and getters. That will however require more work. Line 225: } Line 226: Line 227: private void requireAll(String... mandatoryProperties) { Line 228: for (String property : mandatoryProperties) { -- To view, visit http://gerrit.ovirt.org/24018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
