Alon Bar-Lev has posted comments on this change. Change subject: tools: implement and use transport.idle(). ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/24472/2/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java: Line 48 Line 49 Line 50 Line 51 Line 52 > I see. I hope you man this 'hank', as all the other required anyway... the same mechanism should be used to trigger idle... I was not aware that for simple delay we use some complex infra, had it been up to me I would have eliminated this infra as the benefit is minor... but as long as we have it, we should be consistent. http://gerrit.ovirt.org/#/c/24472/2/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in: Line 62: # the notification service cannot connect to the DB. can be empty. Line 63: # Deprecated, use FILTER with DATABASE_UNREACHABLE instead. Line 64: FAILED_QUERIES_NOTIFICATION_RECIPIENTS= Line 65: Line 66: # Wait at least IDLE_INTERVAL seconds before allowing a Transport to become idle. > I see. you call idle() every IDLE_INTERVAL for all transports, while the smtp transport will perform its magic only at the MAIL_SEND_INTERVAL within that interval, this way we can control when specific transport reacts. Line 67: # An idle transport preforms background tasks like sending unsent queue. Line 68: IDLE_INTERVAL=30 Line 69: Line 70: #--------------# -- To view, visit http://gerrit.ovirt.org/24472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c4bafb542d28cb584e0751446d3e327f93e8112 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
