Alon Bar-Lev has posted comments on this change. Change subject: tools: Adds bash completion for engine-manage-domains ......................................................................
Patch Set 1: For the location, you are incorrect: # rpm -qf /usr/share/bash-completion/ yum-3.4.3-111.fc19.noarch glib2-2.36.3-4.fc19.x86_64 As usual /etc is used for site customize rules. For the need, I still stand... we do not need this... usage (--help) is perfectly clear, no need for bash completion in my opinion, nobody actually complained, most products do not have it... it is extra dependency, extra maintenance, utilities are used once in a lifetime. -- To view, visit http://gerrit.ovirt.org/24483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66d9733d9a4e380e40a457370f08483d832527c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
