[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: upgrade only from >= 3.3.2

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: spec: upgrade only from >= 3.3.2 .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/594/ : S

[Engine-patches] Change in ovirt-engine[master]: engine: Log unsupported network update

2014-02-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Log unsupported network update .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23403 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: restapi: Assure network existence when adding a vnic profile

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Assure network existence when adding a vnic profile .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compil

[Engine-patches] Change in ovirt-engine[master]: restapi: Assure network existence when adding a vnic profile

2014-02-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: restapi: Assure network existence when adding a vnic profile .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/24304 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: engine: Change backward compatibility logic for add/update vnic

2014-02-10 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Change backward compatibility logic for add/update vnic .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24263/3/backend/manager/modules/bll/src/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: upgrade only from >= 3.3.2

2014-02-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: packaging: spec: upgrade only from >= 3.3.2 .. Patch Set 3: * Tracker #1054080: OK * Set POST #1054080: OK, already on POST -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: upgrade only from >= 3.3.2

2014-02-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: upgrade only from >= 3.3.2 .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23665 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: gluster: fix releasing lock in task sync-job

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix releasing lock in task sync-job .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: upgrade only from 3.3.z

2014-02-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: upgrade only from 3.3.z .. Patch Set 2: > sandro - please comment if should be fixed per alon's comment, or merged. > thanks I'll push an u

[Engine-patches] Change in ovirt-engine[master]: engine: Update gluster task's info only if job in progress

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Update gluster task's info only if job in progress .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_

[Engine-patches] Change in ovirt-engine[master]: packaging: build: helptag_checker: fix pep8 issue with old pep8

2014-02-10 Thread sbonazzo
Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: build: helptag_checker: fix pep8 issue with old pep8 .. packaging: build: helptag_checker: fix pep8 issue with old pep8 Change-Id: I659c7d

[Engine-patches] Change in ovirt-engine[master]: packaging: build: helptag_checker: fix pep8 issue with old pep8

2014-02-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: build: helptag_checker: fix pep8 issue with old pep8 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24233 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: engine: Log mass network operations

2014-02-10 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Log mass network operations .. engine: Log mass network operations Added logging of mass operations of networking commands so that each network

[Engine-patches] Change in ovirt-engine[master]: engine: Log mass network operations

2014-02-10 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Log mass network operations .. Patch Set 7: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23249 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Fix NPE in DbUserCacheManager

2014-02-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix NPE in DbUserCacheManager .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24290 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: engine: Log unsupported network update

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Log unsupported network update .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: engine: Log mass network operations

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Log mass network operations .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/18046

[Engine-patches] Change in ovirt-engine[master]: gluster: fix releasing lock in task sync-job

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: fix releasing lock in task sync-job .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkst

[Engine-patches] Change in ovirt-engine[master]: engine: Update gluster task's info only if job in progress

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Update gluster task's info only if job in progress .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_c

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior

2014-02-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fix useDnsLookup behavior .. Patch Set 2: regarding the comment from automation - it exists in all branches - i searched by changed-id -- To view, visit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix useDnsLookup behavior .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_find_bugs_gerrit/5278/ : SUCCESS http

[Engine-patches] Change in ovirt-engine[master]: engine: Log unsupported network update

2014-02-10 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Log unsupported network update .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23403/4/backend/manager/modules/bll/src/main/java/org/ovirt/engin

[Engine-patches] Change in ovirt-engine[master]: engine: Add PersistentSetupNetworksParameters

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Add PersistentSetupNetworksParameters .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ge

[Engine-patches] Change in ovirt-engine[master]: engine: Log mass network operations

2014-02-10 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Log mass network operations .. Patch Set 6: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/23249/6//COMMIT_MSG Commit Message: Line 8: Line 9: Add

[Engine-patches] Change in ovirt-engine[master]: engine: Add PersistentSetupNetworksParameters

2014-02-10 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add PersistentSetupNetworksParameters .. engine: Add PersistentSetupNetworksParameters This parameters class will be used to print audit logging

[Engine-patches] Change in ovirt-engine[master]: engine: Add PersistentSetupNetworksParameters

2014-02-10 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Add PersistentSetupNetworksParameters .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/23276 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: engine: Use collection for object names

2014-02-10 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Use collection for object names .. engine: Use collection for object names For nameable objects, there's no need to use a list for creating a se

[Engine-patches] Change in ovirt-engine[master]: engine: Use collection for object names

2014-02-10 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Use collection for object names .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24262 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior

2014-02-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix useDnsLookup behavior .. Patch Set 2: WARNING: This patch was not merged yet on all the newer branches Missing on: ovirt-engine-3.4 -- To vi

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior

2014-02-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix useDnsLookup behavior .. Patch Set 2: * Tracker #1063286: OK * Set POST #1063286: OK, already on POST -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: engine: Update gluster task's info only if job in progress

2014-02-10 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine: Update gluster task's info only if job in progress .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/24151/2/backend/manager/modules/bll/src/main/j

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: improve audit log when creating diskless template

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: improve audit log when creating diskless template .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_ger

[Engine-patches] Change in ovirt-engine[master]: engine: Update gluster task's info only if job in progress

2014-02-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Update gluster task's info only if job in progress .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/24151/2/backend/manager/modules/bll/src/mai

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: improve audit log when creating diskless template

2014-02-10 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: improve audit log when creating diskless template .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24307 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: improve audit log when creating diskless template

2014-02-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: improve audit log when creating diskless template .. Patch Set 1: * Tracker #1053544: OK * Set POST #1053544: OK -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: improve audit log when creating diskless template

2014-02-10 Thread oourfali
Oved Ourfali has uploaded a new change for review. Change subject: core: improve audit log when creating diskless template .. core: improve audit log when creating diskless template Change-Id: I99c88bbc84e19fef06d54bd25567500b05

[Engine-patches] Change in ovirt-engine[master]: engine: Update gluster task's info only if job in progress

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Update gluster task's info only if job in progress .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_

[Engine-patches] Change in ovirt-engine[master]: engine: Update gluster task's info only if job in progress

2014-02-10 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine: Update gluster task's info only if job in progress .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24151/1//COMMIT_MSG Commit Message: Line 3: Au

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior

2014-02-10 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: fix useDnsLookup behavior .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24306/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/domain

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior

2014-02-10 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: fix useDnsLookup behavior .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24306 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix useDnsLookup behavior .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_find_bugs_gerrit/5277/ : SUCCESS http

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior

2014-02-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix useDnsLookup behavior .. Patch Set 1: * Tracker #1063286: OK * Set POST #1063286: OK -- To view, visit http://gerrit.ovirt.org/24306 To unsubs

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior

2014-02-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: fix useDnsLookup behavior .. Patch Set 1: WARNING: This patch was not merged yet on all the newer branches Missing on: ovirt-engine-3.4 -- To vi

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix useDnsLookup behavior

2014-02-10 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: fix useDnsLookup behavior .. core: fix useDnsLookup behavior This patch fixes the usage of "useDnsLookup" flag at engine-manage-domains configuration. on

[Engine-patches] Change in ovirt-reports[master]: packaging: using patches to customize war instead of overwrites

2014-02-10 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: using patches to customize war instead of overwrites .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24275/3/packaging/setup/plugins/ovirt-eng

[Engine-patches] Change in ovirt-engine[master]: core: Support detach Storage Domain with disks.

2014-02-10 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Support detach Storage Domain with disks. .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/24286/1/backend/manager/modules/bll/src/main/java/org/ovirt

[Engine-patches] Change in ovirt-engine[master]: core: Add a validation when deactivate ISO domain.

2014-02-10 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Add a validation when deactivate ISO domain. .. Patch Set 14: So if I have a data center of 1000 VMs in up status, when I'll want to deactivate the data cente

[Engine-patches] Change in ovirt-engine-cli[master]: cli: Check that the --max option has a value

2014-02-10 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: cli: Check that the --max option has a value .. Abandoned Replaced by http://gerrit.ovirt.org/24305 . -- To view, visit http://gerrit.ovirt.org/24080 To unsubscribe, v

[Engine-patches] Change in ovirt-engine-sdk[master]: codegen, sdk: Use Nothing instead of None

2014-02-10 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: codegen, sdk: Use Nothing instead of None .. codegen, sdk: Use Nothing instead of None Currently whe use None to indicate as the default value for optional par

[Engine-patches] Change in ovirt-reports[master]: packaging: using patches to customize war instead of overwrites

2014-02-10 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: using patches to customize war instead of overwrites .. Patch Set 3: (6 comments) patch directory should be categorized and ordered, so no conflicts w

[Engine-patches] Change in ovirt-engine[master]: restapi: Assure network existence when adding a vnic profile

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Assure network existence when adding a vnic profile .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compil

[Engine-patches] Change in ovirt-engine[master]: restapi: Assure network existence when adding a vnic profile

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Assure network existence when adding a vnic profile .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master

[Engine-patches] Change in ovirt-engine[master]: restapi: Assure network existence when adding a vnic profile

2014-02-10 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: restapi: Assure network existence when adding a vnic profile .. restapi: Assure network existence when adding a vnic profile In order to create a vnic profile, th

[Engine-patches] Change in ovirt-reports[master]: packaging: using patches to customize war instead of overwrites

2014-02-10 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: using patches to customize war instead of overwrites .. Patch Set 3: (6 comments) http://gerrit.ovirt.org/#/c/24275/3/Makefile File Makefile: Line 18

[Engine-patches] Change in ovirt-engine[master]: tools: Support snmp trap as a notification method.

2014-02-10 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. .. Patch Set 23: (1 comment) Great! Finally a pure snmp patch!!! this what the work should have been done, c

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-10 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 3: (18 comments) well, I am very tired. you change code by the name of some java god I do not

[Engine-patches] Change in ovirt-engine[master]: core: Fix DiskImageByDiskAliasComparator to handle null alia...

2014-02-10 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: core: Fix DiskImageByDiskAliasComparator to handle null aliases correctly .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24269/1//COMMIT_MSG Commit Me

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-10 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. webadmin: Add confirmation window when deactivating a VM disk Change-Id: I13d9aa5386efd67

[Engine-patches] Change in ovirt-engine[master]: core: Change existing disk validation CDA message in case of...

2014-02-10 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: core: Change existing disk validation CDA message in case of null disk alias .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24276/1/back

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Confirmation window when putting storage domain on...

2014-02-10 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. webadmin: Confirmation window when putting storage domain on maintenance Chan

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Confirmation window when putting storage domain on...

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tes

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Confirmation window when putting storage domain on...

2014-02-10 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24267 To unsubscr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-10 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24266 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: engine: Only iSCSI storage connections are viable for iSCSI ...

2014-02-10 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond .. Patch Set 3: ping... -- To view, visit http://gerrit.ovirt.org/23720 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Confirmation window when putting storage domain on...

2014-02-10 Thread iheim
Itamar Heim has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit http://gerrit.ovirt.org/24267

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-10 Thread iheim
Itamar Heim has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit http://gerrit.ovirt.org/24266 To unsubscr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Confirmation window when putting storage domain on...

2014-02-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. Patch Set 2: * Tracker #1018847: OK * Set POST #1018847: OK, already on POST

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 2: * Tracker #1038980: OK * Set POST #1038980: OK, already on POST -- To view

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Confirmation window when putting storage domain on...

2014-02-10 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. Patch Set 1: It seems like this bug doesn't contain any privileged information so I

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: engine: added HelpTagType to HelpTag

2014-02-10 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: engine: added HelpTagType to HelpTag .. engine: added HelpTagType to HelpTag Added a HelpTagType enum, and references to it in HelpTag. It's not used in G

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-10 Thread iheim
Itamar Heim has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 1: please rebase manually as well by now... -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: tools: remove sql link between notification_subscribers and ...

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: remove sql link between notification_subscribers and users. .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-10 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 1: I changed target version to 3.4. -- To view, visit http://gerrit.ovirt.org/24266

[Engine-patches] Change in ovirt-engine[master]: tools: remove sql link between notification_subscribers and ...

2014-02-10 Thread dcaroest
David Caro has posted comments on this change. Change subject: tools: remove sql link between notification_subscribers and users. .. Patch Set 1: Rerun-Hooks: all Ignore this comment please, doing some tests -- To view, vis

[Engine-patches] Change in ovirt-engine[master]: utils: add getProperty with an optionalSuffix String.

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add getProperty with an optionalSuffix String. .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyl

[Engine-patches] Change in ovirt-engine[master]: tools: fix SmtpTest.

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: fix SmtpTest. .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/18038/ : FAI

[Engine-patches] Change in ovirt-engine[master]: tools: more changes in NotificationProperties

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: more changes in NotificationProperties .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checks

[Engine-patches] Change in ovirt-engine[master]: tools: Support snmp trap as a notification method.

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. .. Patch Set 23: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_

[Engine-patches] Change in ovirt-engine[master]: tools: Notification properties changes.

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Notification properties changes. .. Patch Set 13: -Verified Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checksty

[Engine-patches] Change in ovirt-engine[master]: tools: Remove auxiliary email address from EventSender inter...

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Remove auxiliary email address from EventSender interface .. Patch Set 16: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_m

[Engine-patches] Change in ovirt-engine[master]: tools: notifier - simple first match include/exclude.

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: notifier - simple first match include/exclude. .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compil

[Engine-patches] Change in ovirt-engine[master]: tools: Rename EventNotificationMethods to EventNotificationM...

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Rename EventNotificationMethods to EventNotificationMethod. .. Patch Set 12: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engin

[Engine-patches] Change in ovirt-engine[master]: tools: Refactor model and DB mapping of eventNotificationMet...

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Refactor model and DB mapping of eventNotificationMethods. .. Patch Set 30: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine

[Engine-patches] Change in ovirt-engine[master]: tools: Reorganize notifier.

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Reorganize notifier. .. Patch Set 11: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/18030

[Engine-patches] Change in ovirt-engine[master]: tools: Required changes in events data mapping.

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Required changes in events data mapping. .. Patch Set 14: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_compile_che

[Engine-patches] Change in ovirt-engine[master]: engine: typo fix in README.manual

2014-02-10 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: engine: typo fix in README.manual .. engine: typo fix in README.manual fixed typo. Change-Id: I1776fa24f28f3ab038fff1b9a6b99e45e07f Signed-off-by:

[Engine-patches] Change in ovirt-engine[master]: engine: typo fix in README.manual

2014-02-10 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: typo fix in README.manual .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24284 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: engine: typo fix in README.manual

2014-02-10 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: typo fix in README.manual .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24284 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine-sdk-java[master]: codegen: Use SDK specific JAXB bindings

2014-02-10 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: codegen: Use SDK specific JAXB bindings .. codegen: Use SDK specific JAXB bindings Currently the SDK uses the same JAXB global bindings used by the engine, bec

[Engine-patches] Change in ovirt-engine[master]: tools: fix SmtpTest.

2014-02-10 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: tools: fix SmtpTest. .. tools: fix SmtpTest. Change-Id: I040014e8afaa19db0b5127fac2712b874806e4b8 Signed-off-by: Mooli Tayer --- R backend/manager/tools/src/tes

[Engine-patches] Change in ovirt-engine[master]: tools: remove sql link between notification_subscribers and ...

2014-02-10 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: tools: remove sql link between notification_subscribers and users. .. tools: remove sql link between notification_subscribers and users. This is done in preperat

[Engine-patches] Change in ovirt-engine[master]: tools: more changes in NotificationProperties

2014-02-10 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: tools: more changes in NotificationProperties .. tools: more changes in NotificationProperties split validate into sub calls (validateBasic, validateEmail ...) to

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: engine: added HelpTagType to HelpTag

2014-02-10 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: added HelpTagType to HelpTag .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24295 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: engine: added HelpTagType to HelpTag

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: added HelpTagType to HelpTag .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/589/ : SUCCESS

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: refresh bookmarks

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: refresh bookmarks .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/588/ : SUCCESS -- To v

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: packaging: spec: upgrade only from 3.3.z

2014-02-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: spec: upgrade only from 3.3.z .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/587/ : SUCC

[Engine-patches] Change in ovirt-engine[master]: packaging: build: helptag_checker: fix pep8 issue with old pep8

2014-02-10 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: packaging: build: helptag_checker: fix pep8 issue with old pep8 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24233 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: engine: added HelpTagType to HelpTag

2014-02-10 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: engine: added HelpTagType to HelpTag .. Patch Set 3: rebased -- To view, visit http://gerrit.ovirt.org/24295 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: userportal: allow links in MOTD

2014-02-10 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: userportal: allow links in MOTD .. userportal: allow links in MOTD - Added the ability for admins to add links in the MOTD in the user portal. These lin

  1   2   3   4   5   6   >