Alon Bar-Lev has posted comments on this change. Change subject: packaging: using patches to customize war instead of overwrites ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24275/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 807: '/usr/bin/patch', Line 808: '-p2', Line 809: '-i', Line 810: p, Line 811: ), please add: --batch --silent --reject-file - please after interval, remove all *.orig from directory recursive, this should be done using walk. Line 812: cwd=( Line 813: oreportscons.FileLocations. Line 814: OVIRT_ENGINE_REPORTS_JASPER_WAR Line 815: ), -- To view, visit http://gerrit.ovirt.org/24275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0becc8ef9206fa077547682fd4c299fa5491b15 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
