Mike Kolesnik has posted comments on this change. Change subject: engine: Log unsupported network update ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23403/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java: Line 73: applyNetworkChangesToHosts(); Line 74: } else { Line 75: List<VdsNetworkInterface> nics = Line 76: getDbFacade().getInterfaceDao().getVdsInterfacesByNetworkId(getNetwork().getId()); Line 77: if (!nics.isEmpty()) { > I think that this check by its own will produce more than required noise in Done Line 78: AuditLogDirector.log(this, AuditLogType.MULTI_UPDATE_NETWORK_NOT_POSSIBLE); Line 79: } Line 80: } Line 81: } -- To view, visit http://gerrit.ovirt.org/23403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b37fbdec5134b3131c1cafb1cd9e0596c2efb74 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
