Alon Bar-Lev has posted comments on this change. Change subject: packaging: using patches to customize war instead of overwrites ......................................................................
Patch Set 3: (6 comments) patch directory should be categorized and ordered, so no conflicts when added. I suggest the following: category#_index#_category_description 100_001_meta-inf_add-postgresql-jdbc-module-dependency.patch 200_001_web-inf_add-reports-status-servlet.patch 200_002_web-inf_enforce-ssl.patch 200_002_web-inf_use-war-jboss-faces.patch 300_001_jsp_change-login-help-info.patch 300_002_jsp_fix-sso-resend-issue.patch 300_003_jsp_rebrand-tab-headers.patch 900_001_props_disable-heartbeat-reporting.patch 900_002_props_enable-full-text-in-supported-formats.patch 900_003_props_fix-column-headers-disappearing-in-reports.patch http://gerrit.ovirt.org/#/c/24275/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-02-10 16:53:30 +0200 Line 4: Commit: Yaniv Dary <yd...@redhat.com> Line 5: CommitDate: 2014-02-10 17:24:52 +0200 Line 6: Line 7: packaging: using patches to customize war instead of overwrites we use packaging: setup: for setup related Line 8: Line 9: Change-Id: If0becc8ef9206fa077547682fd4c299fa5491b15 http://gerrit.ovirt.org/#/c/24275/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 760 Line 761 Line 762 Line 763 Line 764 I am quite sure this can be patch as well. Line 775 Line 776 Line 777 Line 778 Line 779 this as well Line 791 Line 792 Line 793 Line 794 Line 795 what about this? http://gerrit.ovirt.org/#/c/24275/3/packaging/war-patches/enable-sso-by-default.patch File packaging/war-patches/enable-sso-by-default.patch: ssl? Line 1: --- a/ovirt-engine-reports.war/WEB-INF/web.xml Line 2: +++ b/ovirt-engine-reports.war/WEB-INF/web.xml Line 3: @@ -551,10 +551,10 @@ Line 4: <url-pattern>/*</url-pattern> http://gerrit.ovirt.org/#/c/24275/3/packaging/war-patches/fix-sso-resend-issue.patch File packaging/war-patches/fix-sso-resend-issue.patch: Line 3: @@ -24,7 +24,6 @@ Line 4: <c:if test="${needPageRefresh}"> Line 5: <script type="text/javascript"> Line 6: <%-- HTTP redirect can't be applied here because it adds jsessionid parameter --%> Line 7: - window.location.reload(); not sure why you do not set needPageRefresh to false Line 8: </script> Line 9: </c:if> -- To view, visit http://gerrit.ovirt.org/24275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0becc8ef9206fa077547682fd4c299fa5491b15 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
