Mike Kolesnik has posted comments on this change. Change subject: engine: Change backward compatibility logic for add/update vnic ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24263/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java: Line 58: return i.getId().equals(getParameters().getInterface().getId()); Line 59: } Line 60: }); Line 61: Line 62: if (oldIface == null) { Shouldn't you return some "not found" error in this case? Line 63: return false; Line 64: } Line 65: Line 66: if (!updateVnicForBackwardCompatibility(oldIface)) { -- To view, visit http://gerrit.ovirt.org/24263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
