Martin Peřina has posted comments on this change. Change subject: core: fix useDnsLookup behavior ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24306/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java: Line 707: useDnsLookup = utilityConfiguration.getUseDnsLookup(); Line 708: if (!ldapServers && useDnsLookup) { Line 709: // The arguments do not contain a list of ldap servers, the 725 Line 710: // kerberos configuration should not be created according to it if 726 Line 711: // useDnsLookup is set to true as in this case the kdc and the domain_realm info Yair, please fix the comment. I noticed that too late for 3.4 branch, so I fixed that in 23842. Line 712: ldapServersPerGSSAPIDomains = Collections.emptyMap(); Line 713: } Line 714: krbConfCreator = new KrbConfCreator(gssapiDomainsString, useDnsLookup, ldapServersPerGSSAPIDomains); Line 715: StringBuffer buffer = null; -- To view, visit http://gerrit.ovirt.org/24306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic96e2f9fafcac1e6ba952a198bfb9cecc160ba8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
