[Engine-patches] Change in ovirt-engine[master]: compat: rename methods to begin with lowercase letter

2014-02-04 Thread iheim
Itamar Heim has posted comments on this change. Change subject: compat: rename methods to begin with lowercase letter .. Patch Set 4: does anything remain post a rebase? -- To view, visit http://gerrit.ovirt.org/14647 To unsu

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Improve audit_log seach query

2014-02-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Improve audit_log seach query .. Patch Set 3: * Tracker #1061165: OK * Set POST #1061165: OK, already on POST -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: compat: rename methods to begin with lowercase letter

2014-02-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: compat: rename methods to begin with lowercase letter .. Patch Set 4: I see some of this already got merged - for example - changes at DateTime. -- To view, v

[Engine-patches] Change in ovirt-engine[master]: compat: rename methods to begin with lowercase letter

2014-02-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: compat: rename methods to begin with lowercase letter .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/14647 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: backward compatibility for monitor devices

2014-02-04 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: backward compatibility for monitor devices .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24046 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Fix templates search query

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix templates search query .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_3.3_find_bugs_gerrit/5268/ : FAILU

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Improve audit_log seach query

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Improve audit_log seach query .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_3.3_find_bugs_gerrit/5267/ : FA

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Fix templates search query

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix templates search query .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_3.3_find_bugs_gerrit/5270/ : FAILU

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Improve audit_log seach query

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Improve audit_log seach query .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_3.3_find_bugs_gerrit/5269/ : FA

[Engine-patches] Change in ovirt-engine[master]: engine: event subscribtion support for gluster events

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: event subscribtion support for gluster events .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_g

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: gluster:Datatype change for bytesRead & bytesWritten from in...

2014-02-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: gluster:Datatype change for bytesRead & bytesWritten from int to long. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23932 To unsubs

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Fix templates search query

2014-02-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix templates search query .. Patch Set 2: * Tracker #1061185: OK * Set POST #1061185: OK -- To view, visit http://gerrit.ovirt.org/24095 To unsub

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Improve audit_log seach query

2014-02-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Improve audit_log seach query .. Patch Set 2: * Tracker #1061165: OK * Set POST #1061165: OK -- To view, visit http://gerrit.ovirt.org/24094 To un

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Fix templates search query

2014-02-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix templates search query .. Patch Set 1: * Tracker #1057561: OK * Set POST #1057561: OK -- To view, visit http://gerrit.ovirt.org/24095 To unsub

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Fix templates search query

2014-02-04 Thread lzelkha
Liran Zelkha has uploaded a new change for review. Change subject: core: Fix templates search query .. core: Fix templates search query This patch improves the performance of the SearchQuery mechanism for the vm_templates view

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Improve audit_log seach query

2014-02-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Improve audit_log seach query .. Patch Set 1: * Tracker #1056064: OK * Set POST #1056064: OK -- To view, visit http://gerrit.ovirt.org/24094 To un

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Improve audit_log seach query

2014-02-04 Thread lzelkha
Liran Zelkha has uploaded a new change for review. Change subject: core: Improve audit_log seach query .. core: Improve audit_log seach query This patch improves the performance of the SearchQuery mechanism for the audit_log tab

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Warn about incompatible upgrade

2014-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: core, webadmin: Warn about incompatible upgrade .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24028 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: webadmin: guide me local cluster - added note on sd

2014-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: guide me local cluster - added note on sd .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24074/1/frontend/webadmin/modules/uicompat/src/main/ja

[Engine-patches] Change in ovirt-engine[master]: core: storage active validation on AddVmFromSnapshot

2014-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: storage active validation on AddVmFromSnapshot .. Patch Set 1: There's no test file for this class. Should be added in another context.. -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: engine: Rephrase confusing audit log message

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Rephrase confusing audit log message .. Patch Set 2: Verified+1 Ayal reviewed the message as a native speaker so I assume this is fine now. Can we merge

[Engine-patches] Change in ovirt-engine[master]: engine: Validate that IDE disk is not read-only

2014-02-04 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: engine: Validate that IDE disk is not read-only .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23953 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Confirmation window when putting storage domain on...

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/24023 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/24024 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: restapi : Missing opertions for snapshots in RESTAPI

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: restapi : Missing opertions for snapshots in RESTAPI .. Patch Set 3: Maor, I am missing changes in FeaturesHelper. But I leave it to Huan's decision. Please, d

[Engine-patches] Change in ovirt-engine[master]: engine: Add action type for previewed snapshot.

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Add action type for previewed snapshot. .. Patch Set 11: (5 comments) http://gerrit.ovirt.org/#/c/20420/11//COMMIT_MSG Commit Message: Line 6: Line 7:

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: creating extension-manager module

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: creating extension-manager module .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/148

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: gluster:Datatype change for bytesRead & bytesWritten from in...

2014-02-04 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster:Datatype change for bytesRead & bytesWritten from int to long. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23932 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Cleaning up common from authentication code.

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] core: Cleaning up common from authentication code. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Cleaning up common from authentication code.

2014-02-04 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: [WIP] core: Cleaning up common from authentication code. .. [WIP] core: Cleaning up common from authentication code. Only "business entities" related code will

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: creating extension-manager module

2014-02-04 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: [WIP] core: creating extension-manager module .. [WIP] core: creating extension-manager module This module will hold all required classes for loading and manag

[Engine-patches] Change in ovirt-engine[master]: engine: Validate that IDE disk is not read-only

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Validate that IDE disk is not read-only .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent selection of IDE disk as read-only in UI

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_master_u

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent selection of IDE disk as read-only in UI

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI .. Patch Set 3: Daniel, let's continue our discussion in the clean patch set. Rebase. -- To view, v

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent selection of IDE disk as read-only in UI

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23998/2/frontend/webadmin/modules/uicommonweb

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Default DC & Cluster has fixed UUIDs

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Default DC & Cluster has fixed UUIDs .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_update_db_to_3.4_latest_gerrit/11

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent selection of IDE disk as read-only in UI

2014-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23998/2/frontend/webadmin/modules/uicommonweb/s

[Engine-patches] Change in ovirt-engine[master]: userportal: allow links in MOTD

2014-02-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: userportal: allow links in MOTD .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24006 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: core: Fix storage validations for extending a disk

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: core: Fix storage validations for extending a disk .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24062 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_

[Engine-patches] Change in ovirt-engine[master]: userportal: allow links in MOTD

2014-02-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: userportal: allow links in MOTD .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/24006 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: webadmin: Confirmation window when putting storage domain on...

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_

[Engine-patches] Change in ovirt-engine[master]: engine: Only iSCSI storage connections are viable for iSCSI ...

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond .. Patch Set 3: somebody, please? -- To view, visit http://gerrit.ovirt.org/23720 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent selection of IDE disk as read-only in UI

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI .. Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/23998/2/frontend/webadmin/modules/uicommonwe

[Engine-patches] Change in ovirt-engine[master]: webadmin: Confirmation window when putting storage domain on...

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24023/2/frontend/webadmin/modu

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Fix templates search query

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix templates search query .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/493/ : SUCCESS --

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Default DC & Cluster has fixed UUIDs

2014-02-04 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: Default DC & Cluster has fixed UUIDs .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24087/1/packaging/dbscripts/insert_data.sql File packaging/dbscrip

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Incorrect mapping: DWH_STOPPED - History Service Started

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Incorrect mapping: DWH_STOPPED - History Service Started .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_ge

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/4

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/4

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Default DC & Cluster has fixed UUIDs

2014-02-04 Thread emesika
Eli Mesika has posted comments on this change. Change subject: Default DC & Cluster has fixed UUIDs .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24087 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: Change NIC type from sPAPR VLAN to any other .. core: Change NIC type from sPAPR VLAN to any other After created the VM, added a network interface a

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 2: * Tracker #1060729: OK * Set POST #1060729: OK, already on POST -- To view, visit htt

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Default DC & Cluster has fixed UUIDs

2014-02-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Default DC & Cluster has fixed UUIDs .. Patch Set 1: * Tracker #1026885: OK * Set POST #1026885: OK, already on POST -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: Default DC & Cluster has fixed UUIDs

2014-02-04 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: Default DC & Cluster has fixed UUIDs .. Default DC & Cluster has fixed UUIDs This patch modifies the uuid_generate_v1 function to have some randomization i

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Improve audit_log seach query

2014-02-04 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: Improve audit_log seach query .. core: Improve audit_log seach query This patch improves the performance of the SearchQuery mechanism for the audit_

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Fix templates search query

2014-02-04 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: Fix templates search query .. core: Fix templates search query This patch improves the performance of the SearchQuery mechanism for the vm_templates

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Default DC & Cluster has fixed UUIDs

2014-02-04 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: Default DC & Cluster has fixed UUIDs .. Default DC & Cluster has fixed UUIDs This patch modifies the uuid_generate_v1 function to have some randomization in its le

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 3: * Tracker #1060729: OK * Set POST #1060729: OK, already on POST -- To view, visit htt

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Fix templates search query

2014-02-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Fix templates search query .. Patch Set 2: * Tracker #1057561: OK * Set POST #1057561: OK, already on POST -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Incorrect mapping: DWH_STOPPED - History Service Started

2014-02-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Incorrect mapping: DWH_STOPPED - History Service Started .. Patch Set 1: * Tracker #1059228: OK * Set POST #1059228: OK -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: Default DC & Cluster has fixed UUIDs

2014-02-04 Thread emesika
Eli Mesika has posted comments on this change. Change subject: Default DC & Cluster has fixed UUIDs .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23853 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Incorrect mapping: DWH_STOPPED - History Service Started

2014-02-04 Thread emesika
Eli Mesika has posted comments on this change. Change subject: Incorrect mapping: DWH_STOPPED - History Service Started .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24086 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: Incorrect mapping: DWH_STOPPED - History Service Started

2014-02-04 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: Incorrect mapping: DWH_STOPPED - History Service Started .. Incorrect mapping: DWH_STOPPED - History Service Started Events are switched : AuditLogType___DWH_STOP

[Engine-patches] Change in ovirt-engine[master]: engine: Remove javadoc from one of DiskValidator APIs

2014-02-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Remove javadoc from one of DiskValidator APIs .. Patch Set 3: (3 comments) See my comments inside the code. I am not against javadocs in general, but t

[Engine-patches] Change in ovirt-engine[master]: Incorrect mapping: DWH_STOPPED - History Service Started

2014-02-04 Thread emesika
Eli Mesika has posted comments on this change. Change subject: Incorrect mapping: DWH_STOPPED - History Service Started .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23890 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: Incorrect mapping: DWH_STOPPED - History Service Started

2014-02-04 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: Incorrect mapping: DWH_STOPPED - History Service Started .. Incorrect mapping: DWH_STOPPED - History Service Started Events are switched : AuditLogType___

[Engine-patches] Change in ovirt-engine[master]: webadmin: Disable port mirroring for external networks

2014-02-04 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Disable port mirroring for external networks .. webadmin: Disable port mirroring for external networks Operation was blocked by backend, but not

[Engine-patches] Change in ovirt-engine[master]: webadmin: Disable port mirroring for external networks

2014-02-04 Thread masayag
Moti Asayag has posted comments on this change. Change subject: webadmin: Disable port mirroring for external networks .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23873 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine: Reduce redundant vm fetch from db

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Reduce redundant vm fetch from db .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1482/ :

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix issues with splitter tabs

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Fix issues with splitter tabs .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/491/ : SUCCE

[Engine-patches] Change in ovirt-engine[master]: webadmin: Disable port mirroring for external networks

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Disable port mirroring for external networks .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_g

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Fix templates search query

2014-02-04 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Fix templates search query .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24050 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Improve audit_log seach query

2014-02-04 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Improve audit_log seach query .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24048 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: fixing typo

2014-02-04 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: webadmin: fixing typo .. webadmin: fixing typo "shceduling" -> "scheduling" Change-Id: I616b711893403f733c6fa7ce8e166657841e4612 Bug-Url: https://bugzill

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24078/1//COMMIT_MSG Commit Message: Line 5: CommitDate

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24078 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: [Fix] Add sPAPR VSCSI in the Add Virtual Disk dialog

2014-02-04 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: webadmin: [Fix] Add sPAPR VSCSI in the Add Virtual Disk dialog .. webadmin: [Fix] Add sPAPR VSCSI in the Add Virtual Disk dialog The "Add Virtual Disk" di

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix typo .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1481/ : SUCCESS http://jenkins.o

[Engine-patches] Change in ovirt-engine[master]: webadmin: Prevent selection of IDE disk as read-only in UI

2014-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI .. Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/23998/2/frontend/webadmin/modules/uicommonweb/

[Engine-patches] Change in ovirt-engine[master]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core: Change NIC type from sPAPR VLAN to any other .. core: Change NIC type from sPAPR VLAN to any other After created the VM, added a network interface a

[Engine-patches] Change in ovirt-engine[master]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24014 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix issues with splitter tabs

2014-02-04 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Fix issues with splitter tabs .. Patch Set 1: Verified+1 Back port of fixes for the splitter tabs. -- To view, visit http://gerrit.ovirt.org/24085 T

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Fix issues with splitter tabs

2014-02-04 Thread awels
Alexander Wels has uploaded a new change for review. Change subject: webadmin: Fix issues with splitter tabs .. webadmin: Fix issues with splitter tabs - Fixed issue where if the system tree was minimized the tab to expand wou

[Engine-patches] Change in ovirt-engine[master]: engine: Reduce redundant vm fetch from db

2014-02-04 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Reduce redundant vm fetch from db .. engine: Reduce redundant vm fetch from db There is no justification for fetching vm static when the entire VM entity

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix issues with splitter tabs

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Fix issues with splitter tabs .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/1480/ :

[Engine-patches] Change in ovirt-engine[master]: webadmin: Confirmation window when putting storage domain on...

2014-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Confirmation window when putting storage domain on maintenance .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24023/2/frontend/webadmin/module

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add confirmation window when deactivating a VM disk

2014-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24024 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix issues with splitter tabs

2014-02-04 Thread awels
Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix issues with splitter tabs .. webadmin: Fix issues with splitter tabs - Fixed issue where if the system tree was minimized the tab to ex

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix issues with splitter tabs

2014-02-04 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Fix issues with splitter tabs .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23871 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerri

[Engine-patches] Change in ovirt-engine[master]: compat: rename methods to begin with lowercase letter

2014-02-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: compat: rename methods to begin with lowercase letter .. Patch Set 4: Code-Review+1 cherry-picked it, build (including GWT), seems to work fine. Let's get it me

[Engine-patches] Change in ovirt-engine[master]: core: Change NIC type from sPAPR VLAN to any other

2014-02-04 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: Change NIC type from sPAPR VLAN to any other .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24014 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Allow alignment scan on multiple disks of the same VM

2014-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Allow alignment scan on multiple disks of the same VM .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24047 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Allow alignment scan on multiple disks of the same VM

2014-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Allow alignment scan on multiple disks of the same VM .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24047/1/frontend/webadmin/modules/uicommon

[Engine-patches] Change in ovirt-engine[master]: webadmin: Allow alignment scan on multiple disks of the same VM

2014-02-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Allow alignment scan on multiple disks of the same VM .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24047/1/frontend/webadmin/modules/uicommon

[Engine-patches] Change in ovirt-engine[master]: core: Extract method of snapshot id.

2014-02-04 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Extract method of snapshot id. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20419 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: core: Removing targetSnapshot parameter

2014-02-04 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: Removing targetSnapshot parameter .. Patch Set 3: Code-Review+2 Declaring it as a global variable is indeed redundant but declaring it as a methods variable i

[Engine-patches] Change in ovirt-engine[master]: webadmin: Warn when exporting a VM from template when templa...

2014-02-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Warn when exporting a VM from template when template is not on export .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: use json for documentation mapping files

2014-02-04 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: use json for documentation mapping files .. Patch Set 11: Verified+1 rebased -- To view, visit http://gerrit.ovirt.org/21392 To unsubscr

  1   2   3   4   5   >