Daniel Erez has posted comments on this change.

Change subject: webadmin: Allow alignment scan on multiple disks of the same VM
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24047/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java:

Line 688:         if (getSelectedItems() != null && getEntity() != null) {
Line 689:             ArrayList<Disk> disks = Linq.<Disk> 
cast(getSelectedItems());
Line 690:             for (Disk disk : disks) {
Line 691: 
Line 692:                 if (!(disk instanceof LunDisk) && 
!isDiskOnBlockDevice(disk)) {
> Hmm weird, according to the old code and the wiki page (http://www.ovirt.or
Probably just a bug in the UI, so should be fine then..
Line 693:                     isExecutionAllowed = false;
Line 694:                     break;
Line 695:                 }
Line 696:             }


-- 
To view, visit http://gerrit.ovirt.org/24047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a430fc790979b7d6237511dd4c7adbffb1ab9eb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to