[Engine-patches] Change in ovirt-engine[master]: engine: Reduce redundant vm fetch from db

[masayag]

Moti Asayag has uploaded a new change for review.

Change subject: engine: Reduce redundant vm fetch from db
......................................................................

engine: Reduce redundant vm fetch from db

There is no justification for fetching vm static
when the entire VM entity is already retrieved.

Change-Id: Ia0da7c8eee009c49c000e47b88d1f08611877e2c
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/84/24084/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
index f1d0c77..9753bec 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
@@ -20,7 +20,6 @@
 import org.ovirt.engine.core.common.businessentities.VMStatus;
 import org.ovirt.engine.core.common.businessentities.VmDevice;
 import org.ovirt.engine.core.common.businessentities.VmDeviceId;
-import org.ovirt.engine.core.common.businessentities.VmStatic;
 import org.ovirt.engine.core.common.businessentities.network.Network;
 import 
org.ovirt.engine.core.common.businessentities.network.VdsNetworkInterface;
 import org.ovirt.engine.core.common.businessentities.network.VmInterfaceType;
@@ -191,7 +190,6 @@
         List<VmNic> allInterfaces = new ArrayList<>(interfaces);
         allInterfaces.remove(oldIface);
         allInterfaces.add(getInterface());
-        VmStatic vm = getVmStaticDAO().get(getVmId());
 
         if (!pciAndIdeWithinLimit(getVm(), allInterfaces)) {
             return false;
@@ -208,7 +206,7 @@
                 || !validate(nicValidator.isCompatibleWithOs())
                 || !validate(nicValidator.emptyNetworkValid())
                 || !validate(nicValidator.hotUpdatePossible())
-                || !validate(nicValidator.profileValid(vm.getVdsGroupId()))) {
+                || 
!validate(nicValidator.profileValid(getVm().getVdsGroupId()))) {
             return false;
         }
 


-- 
To view, visit http://gerrit.ovirt.org/24084
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0da7c8eee009c49c000e47b88d1f08611877e2c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches