Daniel Erez has posted comments on this change. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23998/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java: Line 660: boolean isInternal = (Boolean) getIsInternal().getEntity(); Line 661: DiskInterface diskInterface = (DiskInterface) getDiskInterface().getSelectedItem(); Line 662: getIsSgIoUnfiltered().setIsAvailable(!isInternal && DiskInterface.VirtIO_SCSI.equals(diskInterface)); Line 663: Line 664: if (DiskInterface.IDE.equals(diskInterface) && !Boolean.TRUE.equals(getIsReadOnly().getEntity())) > >getIsReadOnly().setIsChangable(!DiskInterface.IDE.equals(diskInterface))) * 1. what about getIsReadOnly().setIsChangable(!DiskInterface.IDE.equals(diskInterface) && isEditEnabled())). In other words, why do we need to check '!Boolean.TRUE.equals(getIsReadOnly().getEntity())'? * 2. so, are you making sure to pass 'false' in this case? Line 665: { Line 666: getIsReadOnly().setIsChangable(false); Line 667: } Line 668: else if (isEditEnabled()) -- To view, visit http://gerrit.ovirt.org/23998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71856b447abc3bc3a48247c6df2d8e6083e8e783 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
