Daniel Erez has posted comments on this change. Change subject: webadmin: Prevent selection of IDE disk as read-only in UI ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/23998/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java: Line 660: boolean isInternal = (Boolean) getIsInternal().getEntity(); Line 661: DiskInterface diskInterface = (DiskInterface) getDiskInterface().getSelectedItem(); Line 662: getIsSgIoUnfiltered().setIsAvailable(!isInternal && DiskInterface.VirtIO_SCSI.equals(diskInterface)); Line 663: Line 664: if (DiskInterface.IDE.equals(diskInterface) && !Boolean.TRUE.equals(getIsReadOnly().getEntity())) * getIsReadOnly().setIsChangable(!DiskInterface.IDE.equals(diskInterface))) isn't enough? * set IsReadOnly's entity to false when selecting ide Line 665: { Line 666: getIsReadOnly().setIsChangable(false); Line 667: } Line 668: else if (isEditEnabled()) Line 760: @Override Line 761: public ValidationResult validate(Object value) { Line 762: ValidationResult result = new ValidationResult(); Line 763: Line 764: if (getDiskInterface().getSelectedItem() == DiskInterface.IDE && (Boolean) getIsReadOnly().getEntity()) formater Line 765: { Line 766: result.setSuccess(false); Line 767: result.getReasons().add(ConstantsManager.getInstance().getConstants().cannotEnableIdeInterfaceForReadOnlyDisk()); Line 768: } http://gerrit.ovirt.org/#/c/23998/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java: Line 69: getIsInternal().setEntity(false); Line 70: getSizeExtend().setIsAvailable(false); Line 71: } Line 72: Line 73: if (getDisk().getDiskInterface() == DiskInterface.IDE) consider: * getIsReadOnly().setIsChangable(getDisk().getDiskInterface() != DiskInterface.IDE); Line 74: { Line 75: getIsReadOnly().setIsChangable(false); Line 76: } Line 77: } -- To view, visit http://gerrit.ovirt.org/23998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71856b447abc3bc3a48247c6df2d8e6083e8e783 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
